Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Unified Diff: perf_insights/perf_insights/timeline_based_measurement/rendering_frame.html

Issue 1336373002: Port rendering_stats' implementation to javascript (Closed) Base URL: https://github.com/catapult-project/catapult@master
Patch Set: Address Dan's reviews Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: perf_insights/perf_insights/timeline_based_measurement/rendering_frame.html
diff --git a/perf_insights/perf_insights/timeline_based_measurement/rendering_frame.html b/perf_insights/perf_insights/timeline_based_measurement/rendering_frame.html
index 94653929f6a6c2070fc0d320511a2e761be360ec..73a7e1a2be42ed0e8bdc8fdc326e7f701a28da90 100644
--- a/perf_insights/perf_insights/timeline_based_measurement/rendering_frame.html
+++ b/perf_insights/perf_insights/timeline_based_measurement/rendering_frame.html
@@ -83,8 +83,9 @@ tr.exportTo('pi.tbm', function() {
event.title === BEGIN_MAIN_FRAME_EVENT)) {
beginFrameId = event.args['begin_frame_id'];
if (beginFrameId === undefined) {
- throw new Error(
+ var err = new Error(
'Event is missing a beginFrameId.');
+ throw err;
dsinclair 2015/09/22 16:08:31 No need to store err into a variable, just throw n
}
}
beginFrameEventsById[beginFrameId] =

Powered by Google App Engine
This is Rietveld 408576698