Issue 1336363003: Set empty LocalVarDescriptors on execute-once functions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1336363003: Set empty LocalVarDescriptors on execute-once functions (Closed)

Created:
5 years, 3 months ago by hausner

Modified:
5 years, 3 months ago

Reviewers:
rmacnak

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Set empty LocalVarDescriptors on execute-once functions Fixes VM crash when debugger stops while execute-once functions are on the stack, e.g. when evaluating initializer expressions of compile-time constants. BUG=24323 R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/7720e0bed74562f901743bb999344434008cc33d

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	runtime/vm/compiler.cc	View	1	2 chunks	+4 lines, -0 lines	0 comments	Download
	M	runtime/vm/debugger.cc	View	1	1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 4 (1 generated)

rmacnak

LGTM. Please also remove bogus UNREACHABLE from Debugger::GetSavedCurrentContext (bogus even before your change because optimized ...

5 years, 3 months ago (2015-09-14 23:11:14 UTC) #3

hausner

5 years, 3 months ago (2015-09-14 23:26:18 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
7720e0bed74562f901743bb999344434008cc33d (presubmit successful).