Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(446)

Issue 1336353003: fix leaked generator (Closed)

Created:
5 years, 3 months ago by reed1
Modified:
5 years, 3 months ago
Reviewers:
tomhudson
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M tests/ImageDecodingTest.cpp View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 14 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1336353003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1336353003/1
5 years, 3 months ago (2015-09-14 20:03:05 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot/builds/3169)
5 years, 3 months ago (2015-09-14 20:04:54 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1336353003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1336353003/20001
5 years, 3 months ago (2015-09-14 20:30:53 UTC) #6
reed1
ptal
5 years, 3 months ago (2015-09-14 20:34:23 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-14 20:36:42 UTC) #10
tomhudson
lgtm
5 years, 3 months ago (2015-09-14 20:40:24 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1336353003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1336353003/20001
5 years, 3 months ago (2015-09-14 20:40:43 UTC) #13
commit-bot: I haz the power
5 years, 3 months ago (2015-09-14 20:41:27 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/48392b7c631380bc1000e72457c40ce5e7dc2b1e

Powered by Google App Engine
This is Rietveld 408576698