Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(548)

Issue 1336333003: Report data usage UMA for Chrome services (Closed)

Created:
5 years, 3 months ago by amohammadkhan
Modified:
5 years, 3 months ago
CC:
chromium-reviews, tim+watch_chromium.org, cbentzel+watch_chromium.org, sdefresne+watchlist_chromium.org, droger+watchlist_chromium.org, zea+watch_chromium.org, bondd+autofillwatch_chromium.org, rouslan+autofill_chromium.org, blundell+watchlist_chromium.org, maxbogue+watch_chromium.org, browser-components-watch_chromium.org, jdonnelly+autofillwatch_chromium.org, pvalenzuela+watch_chromium.org, rlp+watch_chromium.org, rouslan+spell_chromium.org, asvitkine+watch_chromium.org, estade+watch_chromium.org, groby+spellwatch_chromium.org, plaree+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Report data usage UMA for Chrome services This issue has the same goals as issue 1330443002( It was reverted because it breaded compile on multiple bots). data_use_measurement is a component which records the data use of the services, if a DataUseUserData is attached to their request. Hence to measure and compare data use of different services, a small change is needed in the services' code where they create a URLFetcher. After creating a URLFetcher by a service, a proper tag for that service should be attached to the request. Besides the necessary changes in the service, the enum in DataUseUserData and the function returning the names based on this enum should be updated for different services too. Also the name of target services should be added to proper enum and histograms in histograms.xml file. Lastly the dependency files should be updated accordingly too. TBR=bartfab@chromium.org,andrewhayden@chromium.org,pkasting@chromium.org,sclittle@chromium.org,thestig@chromium.org,isherman@chromium.org,rouslan@chromium.org,nyquist@chromium.org,bengr@chromium.org,asvltkine@chromium.org,zea@chromium.org,mmenke@chromium.org BUG=527304 Committed: https://crrev.com/f76ae11f25dc0056cea63e15c16039fdbd5f3470 Cr-Commit-Position: refs/heads/master@{#348645}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+238 lines, -26 lines) Patch
M chrome/browser/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/profiles/profile_downloader.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/spellchecker/feedback_sender.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/spellchecker/spellcheck_hunspell_dictionary.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/spellchecker/spelling_service_client.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/sync/glue/sync_backend_host_core.cc View 4 chunks +13 lines, -1 line 0 comments Download
M chrome/browser/sync/test/test_http_bridge_factory.h View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/sync/test/test_http_bridge_factory.cc View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M components/autofill.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M components/autofill/core/browser/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M components/autofill/core/browser/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M components/autofill/core/browser/autofill_download_manager.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M components/autofill/core/browser/wallet/real_pan_wallet_client.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M components/data_use_measurement/core/data_use_user_data.h View 1 chunk +13 lines, -0 lines 0 comments Download
M components/data_use_measurement/core/data_use_user_data.cc View 1 chunk +26 lines, -0 lines 0 comments Download
M components/domain_reliability.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M components/domain_reliability/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M components/domain_reliability/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M components/domain_reliability/uploader.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M components/google.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M components/google/core/browser/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M components/google/core/browser/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M components/google/core/browser/google_url_tracker.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M components/invalidation.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M components/invalidation/impl/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M components/invalidation/impl/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M components/invalidation/impl/gcm_network_channel.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M components/metrics.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M components/metrics/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M components/metrics/net/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M components/metrics/net/net_metrics_log_uploader.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M components/omnibox.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M components/omnibox/browser/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M components/omnibox/browser/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M components/omnibox/browser/base_search_provider.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M components/omnibox/browser/search_provider.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M components/omnibox/browser/zero_suggest_provider.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M components/policy/core/common/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M components/policy/core/common/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M components/policy/core/common/cloud/device_management_service.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M components/policy/core/common/cloud/external_policy_data_fetcher.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M components/policy/core/common/cloud/user_info_fetcher.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M components/policy/policy_common.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M components/rappor.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M components/rappor/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M components/rappor/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M components/rappor/log_uploader.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M components/translate.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M components/translate/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M components/translate/core/browser/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M components/translate/core/browser/translate_url_fetcher.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M components/variations.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M components/variations/service/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M components/variations/service/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M components/variations/service/variations_service.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M sync/internal_api/http_bridge.cc View 4 chunks +13 lines, -6 lines 0 comments Download
M sync/internal_api/http_bridge_unittest.cc View 5 chunks +12 lines, -8 lines 0 comments Download
M sync/internal_api/public/http_bridge.h View 4 chunks +12 lines, -2 lines 0 comments Download
M sync/internal_api/public/http_post_provider_factory.h View 2 chunks +9 lines, -1 line 0 comments Download
M sync/internal_api/sync_manager_impl_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M sync/internal_api/syncapi_server_connection_manager_unittest.cc View 1 chunk +3 lines, -1 line 0 comments Download
M sync/test/fake_server/fake_server_http_post_provider.h View 2 chunks +4 lines, -1 line 0 comments Download
M sync/test/fake_server/fake_server_http_post_provider.cc View 1 chunk +3 lines, -1 line 0 comments Download
M sync/tools/sync_client.cc View 2 chunks +2 lines, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 2 chunks +27 lines, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
bengr
lgtm
5 years, 3 months ago (2015-09-14 15:31:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1336333003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1336333003/1
5 years, 3 months ago (2015-09-14 15:38:25 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/106632)
5 years, 3 months ago (2015-09-14 16:52:18 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1336333003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1336333003/1
5 years, 3 months ago (2015-09-14 17:00:00 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-14 17:34:54 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/f76ae11f25dc0056cea63e15c16039fdbd5f3470 Cr-Commit-Position: refs/heads/master@{#348645}
5 years, 3 months ago (2015-09-14 17:35:31 UTC) #10
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:33:41 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f76ae11f25dc0056cea63e15c16039fdbd5f3470
Cr-Commit-Position: refs/heads/master@{#348645}

Powered by Google App Engine
This is Rietveld 408576698