src/snapshot/serialize.cc - Issue 1336313002: VectorICs: ia32 store ics need a virtual register.

Side by Side Diff: src/snapshot/serialize.cc

Issue 1336313002: VectorICs: ia32 store ics need a virtual register. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Code comments. Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright 2012 the V8 project authors. All rights reserved.	1 // Copyright 2012 the V8 project authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "src/snapshot/serialize.h"	5 #include "src/snapshot/serialize.h"

6	6

7 #include "src/accessors.h"	7 #include "src/accessors.h"

8 #include "src/api.h"	8 #include "src/api.h"

9 #include "src/base/platform/platform.h"	9 #include "src/base/platform/platform.h"

10 #include "src/bootstrapper.h"	10 #include "src/bootstrapper.h"

(...skipping 123 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
134	134

135 // Debug addresses	135 // Debug addresses

136 Add(ExternalReference::debug_after_break_target_address(isolate).address(),	136 Add(ExternalReference::debug_after_break_target_address(isolate).address(),

137 "Debug::after_break_target_address()");	137 "Debug::after_break_target_address()");

138 Add(ExternalReference::debug_restarter_frame_function_pointer_address(isolate)	138 Add(ExternalReference::debug_restarter_frame_function_pointer_address(isolate)

139 .address(),	139 .address(),

140 "Debug::restarter_frame_function_pointer_address()");	140 "Debug::restarter_frame_function_pointer_address()");

141 Add(ExternalReference::debug_is_active_address(isolate).address(),	141 Add(ExternalReference::debug_is_active_address(isolate).address(),

142 "Debug::is_active_address()");	142 "Debug::is_active_address()");

143	143

	144 Add(ExternalReference::vector_store_virtual_register(isolate).address(),
	vogelheim 2015/09/14 14:21:58 super nitpick: Maybe move a few lines up, to the e super nitpick: Maybe move a few lines up, to the end of the "regular" references? (Rather than between the debug_* and #ifdef-ed ones?) mvstanton 2015/09/14 14:25:36 Done. Show quoted text On 2015/09/14 14:21:58, vogelheim wrote: > super nitpick: Maybe move a few lines up, to the end of the "regular" > references? (Rather than between the debug_* and #ifdef-ed ones?) Done.
	145 "Isolate::vector_store_virtual_register()");

	146

144 #ifndef V8_INTERPRETED_REGEXP	147 #ifndef V8_INTERPRETED_REGEXP

145 Add(ExternalReference::re_case_insensitive_compare_uc16(isolate).address(),	148 Add(ExternalReference::re_case_insensitive_compare_uc16(isolate).address(),

146 "NativeRegExpMacroAssembler::CaseInsensitiveCompareUC16()");	149 "NativeRegExpMacroAssembler::CaseInsensitiveCompareUC16()");

147 Add(ExternalReference::re_check_stack_guard_state(isolate).address(),	150 Add(ExternalReference::re_check_stack_guard_state(isolate).address(),

148 "RegExpMacroAssembler*::CheckStackGuardState()");	151 "RegExpMacroAssembler*::CheckStackGuardState()");

149 Add(ExternalReference::re_grow_stack(isolate).address(),	152 Add(ExternalReference::re_grow_stack(isolate).address(),

150 "NativeRegExpMacroAssembler::GrowStack()");	153 "NativeRegExpMacroAssembler::GrowStack()");

151 Add(ExternalReference::re_word_character_map().address(),	154 Add(ExternalReference::re_word_character_map().address(),

152 "NativeRegExpMacroAssembler::word_character_map");	155 "NativeRegExpMacroAssembler::word_character_map");

153 Add(ExternalReference::address_of_regexp_stack_limit(isolate).address(),	156 Add(ExternalReference::address_of_regexp_stack_limit(isolate).address(),

(...skipping 2726 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
2880 SerializedCodeData* scd = new SerializedCodeData(cached_data);	2883 SerializedCodeData* scd = new SerializedCodeData(cached_data);

2881 SanityCheckResult r = scd->SanityCheck(isolate, source);	2884 SanityCheckResult r = scd->SanityCheck(isolate, source);

2882 if (r == CHECK_SUCCESS) return scd;	2885 if (r == CHECK_SUCCESS) return scd;

2883 cached_data->Reject();	2886 cached_data->Reject();

2884 source->GetIsolate()->counters()->code_cache_reject_reason()->AddSample(r);	2887 source->GetIsolate()->counters()->code_cache_reject_reason()->AddSample(r);

2885 delete scd;	2888 delete scd;

2886 return NULL;	2889 return NULL;

2887 }	2890 }

2888 } // namespace internal	2891 } // namespace internal

2889 } // namespace v8	2892 } // namespace v8

OLD	NEW

« no previous file with comments | « src/isolate.cc ('k') | no next file » | no next file with comments »