|
[builtins] Remove STRING_ADD_LEFT and STRING_ADD_RIGHT builtins.
These builtins present an optimization for the general addition case,
where one side is already known to be a string. Unfortunately this
optimization is wrong in the presence of @@toPrimitive (there are some
ideas how to implement a similar optimization using the prototype
backpointer mechanism that jkummerow@ introduced earlier). So this
also removes the broken %_IsStringWrapperSafeForDefaultValueOf, which is
the key part of the optimization mentioned above.
R=mstarzinger@chromium.org
BUG= v8:4307
LOG=n
Committed: https://crrev.com/d90a404747bd065d2fe653704222b1e6638ef9e6
Cr-Commit-Position: refs/heads/master@{#30707}
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+20 lines, -793 lines) |
Patch |
|
M |
src/contexts.h
|
View
|
|
1 chunk |
+11 lines, -13 lines |
0 comments
|
Download
|
|
M |
src/full-codegen/arm/full-codegen-arm.cc
|
View
|
|
1 chunk |
+0 lines, -89 lines |
0 comments
|
Download
|
|
M |
src/full-codegen/arm64/full-codegen-arm64.cc
|
View
|
|
1 chunk |
+0 lines, -102 lines |
0 comments
|
Download
|
|
M |
src/full-codegen/full-codegen.h
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
|
M |
src/full-codegen/ia32/full-codegen-ia32.cc
|
View
|
|
1 chunk |
+0 lines, -91 lines |
0 comments
|
Download
|
|
M |
src/full-codegen/mips/full-codegen-mips.cc
|
View
|
|
1 chunk |
+0 lines, -88 lines |
0 comments
|
Download
|
|
M |
src/full-codegen/mips64/full-codegen-mips64.cc
|
View
|
|
1 chunk |
+0 lines, -89 lines |
0 comments
|
Download
|
|
M |
src/full-codegen/ppc/full-codegen-ppc.cc
|
View
|
|
1 chunk |
+0 lines, -91 lines |
0 comments
|
Download
|
|
M |
src/full-codegen/x64/full-codegen-x64.cc
|
View
|
|
1 chunk |
+0 lines, -85 lines |
0 comments
|
Download
|
|
M |
src/full-codegen/x87/full-codegen-x87.cc
|
View
|
|
1 chunk |
+0 lines, -91 lines |
0 comments
|
Download
|
|
M |
src/hydrogen.cc
|
View
|
|
2 chunks |
+8 lines, -6 lines |
0 comments
|
Download
|
|
M |
src/objects.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
src/runtime.js
|
View
|
|
2 chunks |
+0 lines, -39 lines |
0 comments
|
Download
|
|
M |
src/runtime/runtime.h
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
|
M |
src/runtime/runtime-strings.cc
|
View
|
|
1 chunk |
+0 lines, -6 lines |
0 comments
|
Download
|
Total messages: 8 (1 generated)
|