Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 1336273002: [builtins] Remove STRING_ADD_LEFT and STRING_ADD_RIGHT builtins. (Closed)

Created:
5 years, 3 months ago by Benedikt Meurer
Modified:
5 years, 3 months ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[builtins] Remove STRING_ADD_LEFT and STRING_ADD_RIGHT builtins. These builtins present an optimization for the general addition case, where one side is already known to be a string. Unfortunately this optimization is wrong in the presence of @@toPrimitive (there are some ideas how to implement a similar optimization using the prototype backpointer mechanism that jkummerow@ introduced earlier). So this also removes the broken %_IsStringWrapperSafeForDefaultValueOf, which is the key part of the optimization mentioned above. R=mstarzinger@chromium.org BUG=v8:4307 LOG=n Committed: https://crrev.com/d90a404747bd065d2fe653704222b1e6638ef9e6 Cr-Commit-Position: refs/heads/master@{#30707}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -793 lines) Patch
M src/contexts.h View 1 chunk +11 lines, -13 lines 0 comments Download
M src/full-codegen/arm/full-codegen-arm.cc View 1 chunk +0 lines, -89 lines 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 1 chunk +0 lines, -102 lines 0 comments Download
M src/full-codegen/full-codegen.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 1 chunk +0 lines, -91 lines 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 1 chunk +0 lines, -88 lines 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 1 chunk +0 lines, -89 lines 0 comments Download
M src/full-codegen/ppc/full-codegen-ppc.cc View 1 chunk +0 lines, -91 lines 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 1 chunk +0 lines, -85 lines 0 comments Download
M src/full-codegen/x87/full-codegen-x87.cc View 1 chunk +0 lines, -91 lines 0 comments Download
M src/hydrogen.cc View 2 chunks +8 lines, -6 lines 0 comments Download
M src/objects.h View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime.js View 2 chunks +0 lines, -39 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/runtime/runtime-strings.cc View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
Benedikt Meurer
5 years, 3 months ago (2015-09-14 07:56:20 UTC) #1
Benedikt Meurer
Hey Michi, Here's another -770 lines of weird code. Please take a look. Thanks, Benedikt
5 years, 3 months ago (2015-09-14 08:00:56 UTC) #2
Michael Starzinger
LGTM. Love it. Please more of that. As discussed offline, date-format-xparb tanked.
5 years, 3 months ago (2015-09-14 08:34:43 UTC) #3
Benedikt Meurer
On 2015/09/14 08:34:43, Michael Starzinger wrote: > LGTM. Love it. Please more of that. As ...
5 years, 3 months ago (2015-09-14 08:39:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1336273002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1336273002/1
5 years, 3 months ago (2015-09-14 08:39:09 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-14 08:40:50 UTC) #7
commit-bot: I haz the power
5 years, 3 months ago (2015-09-14 08:41:49 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d90a404747bd065d2fe653704222b1e6638ef9e6
Cr-Commit-Position: refs/heads/master@{#30707}

Powered by Google App Engine
This is Rietveld 408576698