Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1336143002: Implement Token Binding Negotiation in tlslite (Closed)

Created:
5 years, 3 months ago by nharper
Modified:
5 years, 3 months ago
Reviewers:
davidben
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Implement Token Binding Negotiation in tlslite BUG=467312 Committed: https://crrev.com/bed44d8777aaa1df759ae2242f6812d3de9625e7 Cr-Commit-Position: refs/heads/master@{#348968}

Patch Set 1 #

Patch Set 2 : Actually include patch #

Total comments: 4

Patch Set 3 : check version number #

Unified diffs Side-by-side diffs Delta from patch set Stats (+153 lines, -0 lines) Patch
M third_party/tlslite/README.chromium View 1 chunk +2 lines, -0 lines 0 comments Download
A + third_party/tlslite/patches/token_binding_negotiation.patch View 1 2 1 chunk +115 lines, -0 lines 0 comments Download
M third_party/tlslite/tlslite/constants.py View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/tlslite/tlslite/handshakesettings.py View 3 chunks +9 lines, -0 lines 0 comments Download
M third_party/tlslite/tlslite/messages.py View 1 2 4 chunks +22 lines, -0 lines 0 comments Download
M third_party/tlslite/tlslite/tlsconnection.py View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
nharper
5 years, 3 months ago (2015-09-12 01:26:42 UTC) #2
davidben
lgtm https://codereview.chromium.org/1336143002/diff/20001/third_party/tlslite/patches/token_binding_negotiation.patch File third_party/tlslite/patches/token_binding_negotiation.patch (right): https://codereview.chromium.org/1336143002/diff/20001/third_party/tlslite/patches/token_binding_negotiation.patch#newcode1 third_party/tlslite/patches/token_binding_negotiation.patch:1: diff --git a/third_party/tlslite/tlslite/constants.py b/third_party/tlslite/tlslite/constants.py [Did not review; assuming ...
5 years, 3 months ago (2015-09-15 15:49:41 UTC) #3
nharper
https://codereview.chromium.org/1336143002/diff/20001/third_party/tlslite/tlslite/messages.py File third_party/tlslite/tlslite/messages.py (right): https://codereview.chromium.org/1336143002/diff/20001/third_party/tlslite/tlslite/messages.py#newcode196 third_party/tlslite/tlslite/messages.py:196: ver_major = p2.get(1) On 2015/09/15 15:49:40, David Benjamin wrote: ...
5 years, 3 months ago (2015-09-15 19:12:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1336143002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1336143002/40001
5 years, 3 months ago (2015-09-15 19:46:41 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 3 months ago (2015-09-15 19:59:42 UTC) #8
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/bed44d8777aaa1df759ae2242f6812d3de9625e7 Cr-Commit-Position: refs/heads/master@{#348968}
5 years, 3 months ago (2015-09-15 20:00:48 UTC) #9
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:48:30 UTC) #10
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/bed44d8777aaa1df759ae2242f6812d3de9625e7
Cr-Commit-Position: refs/heads/master@{#348968}

Powered by Google App Engine
This is Rietveld 408576698