Source/core/html/shadow/MediaControls.cpp - Issue 1336133004: Keep overlay cast button visible long enough for user action

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/shadow/MediaControls.cpp

Issue 1336133004: Keep overlay cast button visible long enough for user action (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Add a test Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/shadow/MediaControls.cpp

diff --git a/Source/core/html/shadow/MediaControls.cpp b/Source/core/html/shadow/MediaControls.cpp

index 5c6780b58c0879ead0b2c7f1b7cb4b62ca04ca7c..3d590fab34d98ac4e65cfa365996b626eb36a30c 100644

--- a/Source/core/html/shadow/MediaControls.cpp

+++ b/Source/core/html/shadow/MediaControls.cpp

@@ -308,7 +308,6 @@ void MediaControls::makeOpaque()

void MediaControls::makeTransparent()

{

m_panel->makeTransparent();

- m_overlayCastButton->setIsWanted(false);

}

bool MediaControls::shouldHideMediaControls(unsigned behaviorFlags) const

@@ -605,6 +604,7 @@ void MediaControls::hideMediaControlsTimerFired(Timer<MediaControls>*)

return;

makeTransparent();

+ m_overlayCastButton->setIsWanted(false);

}

void MediaControls::startHideMediaControlsTimer()

« LayoutTests/media/controls-cast-overlay-slow-fade.html ('K') | « LayoutTests/media/controls-cast-overlay-slow-fade.html ('k') | no next file » | no next file with comments »