Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 1336133003: X87: [builtins] Simplify String constructor code. (Closed)

Created:
5 years, 3 months ago by chunyang.dai
Modified:
5 years, 3 months ago
Reviewers:
Weiliang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [builtins] Simplify String constructor code. port eadfd666318c1dd959d7fac7c27538ef478a8b72 (r30706). original commit message: The String constructor was somewhat complex with a lot of micro optimizations that are not relevant or even misguided. It would be really hard to port that code to ES6, which requires String to be subclassable. So as a first step we reduced the necessary complexity to the bare minimum (also removing the last user of the fairly complex MacroAssembler::LookupNumberStringCache method). This also removes the counters for the String constructor, which were not properly exposed anymore (and not kept in sync with inlined versions of the String constructor anyway). BUG= Committed: https://crrev.com/353db40970cf2e6eed36f544c12a556cb6f90464 Cr-Commit-Position: refs/heads/master@{#30744}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -193 lines) Patch
M src/x87/builtins-x87.cc View 1 chunk +63 lines, -106 lines 0 comments Download
M src/x87/macro-assembler-x87.h View 1 chunk +0 lines, -11 lines 0 comments Download
M src/x87/macro-assembler-x87.cc View 1 chunk +0 lines, -76 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
chunyang.dai
ptal
5 years, 3 months ago (2015-09-15 10:15:45 UTC) #2
Weiliang
lgtm
5 years, 3 months ago (2015-09-15 10:50:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1336133003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1336133003/1
5 years, 3 months ago (2015-09-15 10:50:16 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-15 12:16:40 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-15 12:17:02 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/353db40970cf2e6eed36f544c12a556cb6f90464
Cr-Commit-Position: refs/heads/master@{#30744}

Powered by Google App Engine
This is Rietveld 408576698