Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 1335993002: Don't import win32gui when it's not needed (Closed)

Created:
5 years, 3 months ago by fs
Modified:
5 years, 3 months ago
Reviewers:
Sergey Ulanov
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't import win32gui when it's not needed If --parent-window=... isn't passed, then parent_window will be None, and importing win32gui then is unnecessary. Committed: https://crrev.com/2bf84ec90a3deb73607f561be67c531726254818 Cr-Commit-Position: refs/heads/master@{#348914}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/test/data/native_messaging/native_hosts/echo.py View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
fs
5 years, 3 months ago (2015-09-11 16:23:23 UTC) #2
Sergey Ulanov
LGTM what's the reason --parent-window is missing?
5 years, 3 months ago (2015-09-11 18:25:51 UTC) #3
fs
On 2015/09/11 18:25:51, Sergey Ulanov wrote: ... > what's the reason --parent-window is missing? I ...
5 years, 3 months ago (2015-09-14 07:38:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1335993002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1335993002/1
5 years, 3 months ago (2015-09-15 15:28:16 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-15 17:00:47 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/2bf84ec90a3deb73607f561be67c531726254818 Cr-Commit-Position: refs/heads/master@{#348914}
5 years, 3 months ago (2015-09-15 17:01:23 UTC) #8
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:46:08 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2bf84ec90a3deb73607f561be67c531726254818
Cr-Commit-Position: refs/heads/master@{#348914}

Powered by Google App Engine
This is Rietveld 408576698