Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 133583004: If poppler is disable and native pdf is enabled, we still need SkPDFRasterizer.cpp (Closed)

Created:
6 years, 11 months ago by vandebo (ex-Chrome)
Modified:
6 years, 11 months ago
Reviewers:
epoger, reed1
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

If poppler is disable and native pdf is enabled, we still need SkPDFRasterizer.cpp TBR=reed@google.com NOTREECHECKS=true NOTRY=true Committed: http://code.google.com/p/skia/source/detail?r=13025

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -8 lines) Patch
M gyp/gm.gyp View 2 chunks +5 lines, -3 lines 0 comments Download
M src/utils/SkPDFRasterizer.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/utils/SkPDFRasterizer.cpp View 2 chunks +10 lines, -5 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
vandebo (ex-Chrome)
6 years, 11 months ago (2014-01-10 18:42:11 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/vandebo@chromium.org/133583004/1
6 years, 11 months ago (2014-01-10 18:42:19 UTC) #2
reed1
can we explicitly try this against the 10.8 builder, since that is the one that ...
6 years, 11 months ago (2014-01-10 18:44:09 UTC) #3
vandebo (ex-Chrome)
On 2014/01/10 18:44:09, reed1 wrote: > can we explicitly try this against the 10.8 builder, ...
6 years, 11 months ago (2014-01-10 18:44:49 UTC) #4
reed1
you may have to commit this manually, since the CQ will wait while the tree ...
6 years, 11 months ago (2014-01-10 18:45:37 UTC) #5
reed1
On 2014/01/10 18:45:37, reed1 wrote: > you may have to commit this manually, since the ...
6 years, 11 months ago (2014-01-10 18:45:47 UTC) #6
epoger
On 2014/01/10 18:45:47, reed1 wrote: > On 2014/01/10 18:45:37, reed1 wrote: > > you may ...
6 years, 11 months ago (2014-01-10 18:52:32 UTC) #7
reed1
On 2014/01/10 18:52:32, epoger wrote: > On 2014/01/10 18:45:47, reed1 wrote: > > On 2014/01/10 ...
6 years, 11 months ago (2014-01-10 18:53:59 UTC) #8
epoger
On 2014/01/10 18:53:59, reed1 wrote: > On 2014/01/10 18:52:32, epoger wrote: > > On 2014/01/10 ...
6 years, 11 months ago (2014-01-10 18:56:54 UTC) #9
reed1
On 2014/01/10 18:56:54, epoger wrote: > On 2014/01/10 18:53:59, reed1 wrote: > > On 2014/01/10 ...
6 years, 11 months ago (2014-01-10 18:59:30 UTC) #10
epoger
> > I don't think so, if you specify both NOTREECHECKS and NOTRY. > > ...
6 years, 11 months ago (2014-01-10 19:04:52 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/vandebo@chromium.org/133583004/1
6 years, 11 months ago (2014-01-10 19:08:55 UTC) #12
commit-bot: I haz the power
Change committed as 13025
6 years, 11 months ago (2014-01-10 19:09:03 UTC) #13
vandebo (ex-Chrome)
On 2014/01/10 19:09:03, I haz the power (commit-bot) wrote: > Change committed as 13025 Sorry ...
6 years, 11 months ago (2014-01-10 19:09:34 UTC) #14
epoger
6 years, 11 months ago (2014-01-10 19:12:33 UTC) #15
Message was sent while issue was closed.
On 2014/01/10 19:09:34, vandebo wrote:
> On 2014/01/10 19:09:03, I haz the power (commit-bot) wrote:
> > Change committed as 13025
> 
> Sorry for the delay, I thought TBR would have done several of those.

I can see why you'd think that.

A restatement of the commands, as I understand them:

NOTREECHECKS = don't let a red tree stop you from committing
NOTRY = don't bother with trybots before attempting commit
TBR = don't let a lack-of-LGTM stop you from committing (if author has commit
rights)

Powered by Google App Engine
This is Rietveld 408576698