Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 133583003: Reduce verbosity of SkGraphics::Init in default case. (Closed)

Created:
6 years, 11 months ago by hal.canary
Modified:
6 years, 11 months ago
Reviewers:
mtklein, reed1
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Reduce verbosity of SkGraphics::Init in default case. SkGraphics::Init() now checks to see if there are any non-default runtime configuration options before announcing that it is about to print out the non-default runtime configuration options. This makes the executables in tools/ less verbose. Add SkRTConfRegistry::countNonDefault() function. BUG= R=mtklein@google.com, reed@google.com Committed: https://code.google.com/p/skia/source/detail?r=13017

Patch Set 1 #

Total comments: 2

Patch Set 2 : int to bool #

Patch Set 3 : final rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -2 lines) Patch
M include/utils/SkRTConf.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/core/SkGraphics.cpp View 1 1 chunk +4 lines, -2 lines 0 comments Download
M src/utils/SkRTConf.cpp View 1 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
hal.canary
PTAL
6 years, 11 months ago (2014-01-10 13:30:51 UTC) #1
mtklein
https://codereview.chromium.org/133583003/diff/1/include/utils/SkRTConf.h File include/utils/SkRTConf.h (right): https://codereview.chromium.org/133583003/diff/1/include/utils/SkRTConf.h#newcode78 include/utils/SkRTConf.h:78: int countNonDefault() const; I don't think this matters here ...
6 years, 11 months ago (2014-01-10 13:53:31 UTC) #2
hal.canary
https://codereview.chromium.org/133583003/diff/1/include/utils/SkRTConf.h File include/utils/SkRTConf.h (right): https://codereview.chromium.org/133583003/diff/1/include/utils/SkRTConf.h#newcode78 include/utils/SkRTConf.h:78: int countNonDefault() const; On 2014/01/10 13:53:31, mtklein wrote: > ...
6 years, 11 months ago (2014-01-10 14:30:46 UTC) #3
mtklein
lgtm
6 years, 11 months ago (2014-01-10 14:33:51 UTC) #4
hal.canary
"Since the CL is editing public API, you must have an LGTM from one of: ...
6 years, 11 months ago (2014-01-10 14:56:28 UTC) #5
reed1
lgtm
6 years, 11 months ago (2014-01-10 14:56:59 UTC) #6
hal.canary
6 years, 11 months ago (2014-01-10 15:00:50 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 manually as r13017 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698