Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 133583002: IDL compiler: methods in Node interfaces (Closed)

Created:
6 years, 11 months ago by Nils Barth (inactive)
Modified:
6 years, 11 months ago
Reviewers:
haraken
CC:
blink-reviews, Nils Barth (inactive), kojih, arv+blink, jsbell+bindings_chromium.org, sof, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, Nate Chapin, Inactive
Visibility:
Public.

Description

IDL compiler: methods in Node interfaces BUG=239771 R=haraken NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165015

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -5 lines) Patch
M Source/bindings/scripts/unstable/v8_methods.py View 3 chunks +5 lines, -4 lines 0 comments Download
M Source/bindings/tests/idls/TestInterfaceNode.idl View 1 1 chunk +2 lines, -0 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceNode.cpp View 1 3 chunks +18 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Nils Barth (inactive)
Last Node one. (Has the is_url CL in it.)
6 years, 11 months ago (2014-01-10 10:00:28 UTC) #1
haraken
LGTM.
6 years, 11 months ago (2014-01-10 10:46:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/133583002/50001
6 years, 11 months ago (2014-01-14 01:31:42 UTC) #3
commit-bot: I haz the power
6 years, 11 months ago (2014-01-14 01:49:54 UTC) #4
Message was sent while issue was closed.
Change committed as 165015

Powered by Google App Engine
This is Rietveld 408576698