native_client_sdk/src/tests/nacl_io_test/kernel_proxy_test.cc - Issue 1335783005: [NaCl SDK] nacl_io: Add support for basic socketpairs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: native_client_sdk/src/tests/nacl_io_test/kernel_proxy_test.cc

Issue 1335783005: [NaCl SDK] nacl_io: Add support for basic socketpairs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Class renamed/cl-format applied. Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« native_client_sdk/src/libraries/nacl_io/socket/unixsocket_event_emitter.h ('K') | « native_client_sdk/src/libraries/nacl_io/socket/unixsocket_node.cc ('k') | native_client_sdk/src/tests/nacl_io_test/mock_node.cc » ('j') | native_client_sdk/src/tests/nacl_io_test/mock_node.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: native_client_sdk/src/tests/nacl_io_test/kernel_proxy_test.cc

diff --git a/native_client_sdk/src/tests/nacl_io_test/kernel_proxy_test.cc b/native_client_sdk/src/tests/nacl_io_test/kernel_proxy_test.cc

index 24a0fd10c2de818d047e11785d567427e7f38af4..8d6e4c0ab1c4e361073d25c870024d3e12ff3ac9 100644

--- a/native_client_sdk/src/tests/nacl_io_test/kernel_proxy_test.cc

+++ b/native_client_sdk/src/tests/nacl_io_test/kernel_proxy_test.cc

@@ -1093,6 +1093,7 @@ TEST_F(KernelProxyErrorTest, WriteError) {

.WillOnce(DoAll(SetArgPointee<3>(0), // Wrote 0 bytes.

Return(1234))); // Returned error 1234.

+ EXPECT_CALL(*mock_node, GetType()).WillRepeatedly(Return(S_IFDIR));

Sam Clegg 2015/09/22 17:53:44 Why is this change needed?

avallee 2015/09/22 20:25:06 I'll split this out to a separate CL, this was a c

EXPECT_CALL(*mock_node, IsaDir()).Times(1);

EXPECT_CALL(*mock_node, Destroy()).Times(1);

@@ -1116,6 +1117,7 @@ TEST_F(KernelProxyErrorTest, ReadError) {

.WillOnce(DoAll(SetArgPointee<3>(0), // Read 0 bytes.

Return(1234))); // Returned error 1234.

+ EXPECT_CALL(*mock_node, GetType()).WillRepeatedly(Return(S_IFDIR));

EXPECT_CALL(*mock_node, Destroy()).Times(1);

int fd = ki_open("/dummy", O_RDONLY, 0);