[NaCl SDK] nacl_io: Add support for basic socketpairs.

native_client_sdk/src/tests/nacl_io_test/socket_test.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <arpa/inet.h>
 #include <errno.h>
 #include <fcntl.h>
 #include <netinet/in.h>
 #include <pthread.h>
 #include <sys/types.h>
@@ skipping 236 matching lines @@
   EXPECT_LT(ki_socket(AF_UNIX, SOCK_STREAM, 0), 0);
   EXPECT_EQ(errno, EAFNOSUPPORT);
   EXPECT_LT(ki_socket(AF_INET, SOCK_RAW, 0), 0);
   EXPECT_EQ(errno, EPROTONOSUPPORT);
 }
 
 TEST_F(SocketTest, Socketpair) {
   int sv[2];
   EXPECT_LT(ki_socketpair(AF_INET, SOCK_STREAM, 0, NULL), 0);
   EXPECT_EQ(errno, EFAULT);
-  EXPECT_LT(ki_socketpair(AF_UNIX, SOCK_STREAM, 0, sv), 0);
-  EXPECT_EQ(errno, EAFNOSUPPORT);
   EXPECT_LT(ki_socketpair(AF_INET, SOCK_STREAM, 0, sv), 0);
-  EXPECT_EQ(errno, EPROTONOSUPPORT);
+  EXPECT_EQ(errno, EOPNOTSUPP);
   EXPECT_LT(ki_socketpair(AF_INET6, SOCK_STREAM, 0, sv), 0);
-  EXPECT_EQ(errno, EPROTONOSUPPORT);
+  EXPECT_EQ(errno, EOPNOTSUPP);
+
+  sv[0] = sv[1] = -1;
+  errno = 0;
+  EXPECT_EQ(ki_socketpair(AF_UNIX, SOCK_STREAM, 0, sv), 0);
+  EXPECT_EQ(errno, 0);
+  EXPECT_GE(sv[0], 0);
+  EXPECT_GE(sv[1], 0);

[Sam Clegg, 2015/09/17 09:40:39]

More testing here would be good.  Perhaps a split into several socketpair tests?
  If there is a lot of test code perhaps we can somehow share tests/code with
the TCP tests?

Oh, I just remembered that the TCP/UDP socket tests all live in the
nacl_io_socket_test suite which runs in chrome since we don't have mocks for the
socket API.  However, socketpair tests don't rely on pepper so should all be
testable under sel_ldr here in nacl_io_test.

 }
 
 TEST(SocketUtilityFunctions, Htonl) {
   uint32_t host_long = 0x44332211;
   uint32_t network_long = htonl(host_long);
   uint8_t network_bytes[4];
   memcpy(network_bytes, &network_long, 4);
   EXPECT_EQ(network_bytes[0], 0x44);
   EXPECT_EQ(network_bytes[1], 0x33);
   EXPECT_EQ(network_bytes[2], 0x22);
@@ skipping 257 matching lines @@
 
 TEST(SocketUtilityFunctions, Ntohl) {
   uint8_t network_bytes[4] = { 0x44, 0x33, 0x22, 0x11 };
   uint32_t network_long;
   memcpy(&network_long, network_bytes, 4);
   uint32_t host_long = ntohl(network_long);
   EXPECT_EQ(host_long, 0x44332211);
 }
 
 #endif  // PROVIDES_SOCKETPAIR_API