native_client_sdk/src/tests/nacl_io_test/mock_node.cc - Issue 1335783005: [NaCl SDK] nacl_io: Add support for basic socketpairs.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: native_client_sdk/src/tests/nacl_io_test/mock_node.cc

Issue 1335783005: [NaCl SDK] nacl_io: Add support for basic socketpairs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« native_client_sdk/src/libraries/nacl_io/socket/unix_socketpair_node.cc ('K') | « native_client_sdk/src/tests/nacl_io_test/kernel_proxy_test.cc ('k') | native_client_sdk/src/tests/nacl_io_test/socket_test.cc » ('j') | native_client_sdk/src/tests/nacl_io_test/socket_test.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2013 The Chromium Authors. All rights reserved.	1 // Copyright 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "mock_node.h"	5 #include "mock_node.h"

6	6

7 MockNode::MockNode(nacl_io::Filesystem* mount) : Node(mount) {}	7 using ::testing::Return;

	8

	9 MockNode::MockNode(nacl_io::Filesystem* mount) : Node(mount) {

	10 ON_CALL(*this, GetType()).WillByDefault(Return(S_IFREG));
	Sam Clegg 2015/09/17 09:40:39 Why this change? Why this change? avallee 2015/09/17 16:18:01 Might not be needed, but both read and write now c Show quoted text On 2015/09/17 09:40:39, Sam Clegg wrote: > Why this change? Might not be needed, but both read and write now call gettype (via IsSeekable in my previous patch). The natural intuition is that the default file node type is a regular file. The original unset value 0, is never a valid file type and should not have this value. In the test that expects a directory, I added an expect_call (which probably should also be ON_CALL if that works) to suppress some warnings.
	11 }

8	12

9 MockNode::~MockNode() {}	13 MockNode::~MockNode() {}

OLD	NEW