Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1335673004: [Android] grant READ_EXTERNAL_STORAGE permission when adding WRITE_EXTERNAL_STORAGE. (Closed)

Created:
5 years, 3 months ago by rnephew (Reviews Here)
Modified:
5 years, 2 months ago
Reviewers:
jbudorick
CC:
chromium-reviews, jbudorick+watch_chromium.org, klundberg+watch_chromium.org, yfriedman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] grant READ_EXTERNAL_STORAGE permission when adding WRITE_EXTERNAL_STORAGE. BUG=529897 Committed: https://crrev.com/726cbf6abae8ea2c326501621e3b88ffb685e94c Cr-Commit-Position: refs/heads/master@{#348292}

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Patch Set 3 : #

Total comments: 2

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -8 lines) Patch
M build/android/devil/android/device_utils.py View 1 2 3 2 chunks +6 lines, -6 lines 0 comments Download
M build/android/devil/android/device_utils_test.py View 1 2 2 chunks +19 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (3 generated)
rnephew (Reviews Here)
5 years, 3 months ago (2015-09-10 16:29:45 UTC) #2
jbudorick
https://codereview.chromium.org/1335673004/diff/1/build/android/devil/android/device_utils.py File build/android/devil/android/device_utils.py (right): https://codereview.chromium.org/1335673004/diff/1/build/android/devil/android/device_utils.py#newcode1969 build/android/devil/android/device_utils.py:1969: # crbug.com/529897 is cleared up. I don't particularly want ...
5 years, 3 months ago (2015-09-10 16:31:42 UTC) #3
rnephew (Reviews Here)
https://codereview.chromium.org/1335673004/diff/1/build/android/devil/android/device_utils.py File build/android/devil/android/device_utils.py (right): https://codereview.chromium.org/1335673004/diff/1/build/android/devil/android/device_utils.py#newcode1969 build/android/devil/android/device_utils.py:1969: # crbug.com/529897 is cleared up. On 2015/09/10 16:31:41, jbudorick ...
5 years, 3 months ago (2015-09-10 16:33:38 UTC) #4
jbudorick
https://codereview.chromium.org/1335673004/diff/1/build/android/devil/android/device_utils.py File build/android/devil/android/device_utils.py (right): https://codereview.chromium.org/1335673004/diff/1/build/android/devil/android/device_utils.py#newcode1968 build/android/devil/android/device_utils.py:1968: # TODO(rnephew): Remove manually adding read when write is ...
5 years, 3 months ago (2015-09-10 21:36:21 UTC) #5
rnephew (Reviews Here)
https://codereview.chromium.org/1335673004/diff/1/build/android/devil/android/device_utils.py File build/android/devil/android/device_utils.py (right): https://codereview.chromium.org/1335673004/diff/1/build/android/devil/android/device_utils.py#newcode1968 build/android/devil/android/device_utils.py:1968: # TODO(rnephew): Remove manually adding read when write is ...
5 years, 3 months ago (2015-09-10 21:43:29 UTC) #6
rnephew (Reviews Here)
On 2015/09/10 21:43:29, rnephew1 wrote: > https://codereview.chromium.org/1335673004/diff/1/build/android/devil/android/device_utils.py > File build/android/devil/android/device_utils.py (right): > > https://codereview.chromium.org/1335673004/diff/1/build/android/devil/android/device_utils.py#newcode1968 > ...
5 years, 3 months ago (2015-09-10 22:07:34 UTC) #7
jbudorick
lgtm w/ nit https://codereview.chromium.org/1335673004/diff/40001/build/android/devil/android/device_utils.py File build/android/devil/android/device_utils.py (right): https://codereview.chromium.org/1335673004/diff/40001/build/android/devil/android/device_utils.py#newcode1966 build/android/devil/android/device_utils.py:1966: if ('android.permission.WRITE_EXTERNAL_STORAGE' in permissions nit: do ...
5 years, 3 months ago (2015-09-10 22:56:47 UTC) #8
rnephew (Reviews Here)
https://codereview.chromium.org/1335673004/diff/40001/build/android/devil/android/device_utils.py File build/android/devil/android/device_utils.py (right): https://codereview.chromium.org/1335673004/diff/40001/build/android/devil/android/device_utils.py#newcode1966 build/android/devil/android/device_utils.py:1966: if ('android.permission.WRITE_EXTERNAL_STORAGE' in permissions On 2015/09/10 22:56:46, jbudorick wrote: ...
5 years, 3 months ago (2015-09-10 22:58:56 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1335673004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1335673004/60001
5 years, 3 months ago (2015-09-10 22:59:22 UTC) #12
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 3 months ago (2015-09-11 00:10:30 UTC) #13
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/726cbf6abae8ea2c326501621e3b88ffb685e94c Cr-Commit-Position: refs/heads/master@{#348292}
5 years, 3 months ago (2015-09-11 00:11:17 UTC) #14
commit-bot: I haz the power
5 years, 2 months ago (2015-09-23 12:16:43 UTC) #15
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/726cbf6abae8ea2c326501621e3b88ffb685e94c
Cr-Commit-Position: refs/heads/master@{#348292}

Powered by Google App Engine
This is Rietveld 408576698