Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1826)

Unified Diff: Source/web/WebLocalFrameImpl.cpp

Issue 1335573004: Introduce Range::dispose() for prompt detachment from owner Document. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/editing/spellcheck/SpellCheckRequester.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/WebLocalFrameImpl.cpp
diff --git a/Source/web/WebLocalFrameImpl.cpp b/Source/web/WebLocalFrameImpl.cpp
index 5e2b49ed4ad94f60b53136cab1ed99bba2dc580d..342e1d0dc5dc27821fc42045d5adaa4f574dd29c 100644
--- a/Source/web/WebLocalFrameImpl.cpp
+++ b/Source/web/WebLocalFrameImpl.cpp
@@ -256,6 +256,8 @@ static void frameContentAsPlainText(size_t maxChars, LocalFrame* frame, StringBu
// Select the document body.
RefPtrWillBeRawPtr<Range> range(document->createRange());
+ ScopedDisposal<Range> disposeScope(range);
+
TrackExceptionState exceptionState;
range->selectNodeContents(document->body(), exceptionState);
yosin_UTC9 2015/09/11 01:22:27 We can use |EphemeralRange| here. // ClusterFuzz
sof 2015/09/11 06:32:12 Nice; done, I think.
« no previous file with comments | « Source/core/editing/spellcheck/SpellCheckRequester.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698