Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 1335543002: [turbofan] Remove obsolete --turbo-try-catch flag. (Closed)

Created:
5 years, 3 months ago by Michael Starzinger
Modified:
5 years, 3 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Remove obsolete --turbo-try-catch flag. This removes the aforementioned flag which has been on by default for a while now. Note that this does not control optimization decisions, only the last-resort bailout in the graph builder. R=bmeurer@chromium.org Committed: https://crrev.com/a676da3ae0261a946f1cd8243286c3d5426ac80e Cr-Commit-Position: refs/heads/master@{#30673}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -14 lines) Patch
M src/compiler/ast-graph-builder.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/compiler/test-run-deopt.cc View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/compiler/test-run-jsexceptions.cc View 7 chunks +0 lines, -7 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/test-heap.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
Michael Starzinger
Where we are going, we don't need no flags. :)
5 years, 3 months ago (2015-09-10 09:13:48 UTC) #1
Benedikt Meurer
LGTM! Ship it!
5 years, 3 months ago (2015-09-10 09:14:16 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1335543002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1335543002/1
5 years, 3 months ago (2015-09-10 09:15:29 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-10 09:38:34 UTC) #5
commit-bot: I haz the power
5 years, 3 months ago (2015-09-10 09:38:51 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a676da3ae0261a946f1cd8243286c3d5426ac80e
Cr-Commit-Position: refs/heads/master@{#30673}

Powered by Google App Engine
This is Rietveld 408576698