Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(987)

Issue 1335503006: [GN] Remove cflags_c from objc and cflags_cc from objcxx toolchains (Closed)

Created:
5 years, 3 months ago by Bons
Modified:
5 years, 3 months ago
Reviewers:
brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[GN] Remove cflags_c from objc and cflags_cc from objcxx toolchains //build/config/compiler/BUILD.gn has the following lines which make the declarations in the toolchains superfluous: # Pass the same C/C++ flags to the objective C/C++ compiler. cflags_objc += cflags_c cflags_objcc += cflags_cc R=brettw@chromium.org BUG=none Committed: https://crrev.com/bd1aafe5d735405a27266a38a0af38be2d17d0bd Cr-Commit-Position: refs/heads/master@{#348197}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M build/toolchain/mac/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Bons
5 years, 3 months ago (2015-09-10 17:29:07 UTC) #1
brettw
lgtm
5 years, 3 months ago (2015-09-10 17:36:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1335503006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1335503006/1
5 years, 3 months ago (2015-09-10 17:44:18 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-10 18:30:43 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/bd1aafe5d735405a27266a38a0af38be2d17d0bd Cr-Commit-Position: refs/heads/master@{#348197}
5 years, 3 months ago (2015-09-10 18:34:52 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:12:32 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bd1aafe5d735405a27266a38a0af38be2d17d0bd
Cr-Commit-Position: refs/heads/master@{#348197}

Powered by Google App Engine
This is Rietveld 408576698