Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(507)

Unified Diff: base/trace_event/memory_dump_manager.h

Issue 1335503003: [tracing] Add test for memory-infra startup tracing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@startup_tracing
Patch Set: Nit Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/trace_event/BUILD.gn ('k') | base/trace_event/memory_dump_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/trace_event/memory_dump_manager.h
diff --git a/base/trace_event/memory_dump_manager.h b/base/trace_event/memory_dump_manager.h
index 1092a264830aa1dc1d3280d48aaaf707e4f46d24..4c4a8608b5791001156212f8ecb9b943024ec34e 100644
--- a/base/trace_event/memory_dump_manager.h
+++ b/base/trace_event/memory_dump_manager.h
@@ -105,11 +105,6 @@ class BASE_EXPORT MemoryDumpManager : public TraceLog::EnabledStateObserver {
return kSystemAllocatorPoolName;
};
- // Tells the initialization phase to skip scheduling periodic memory dumps.
- void DisablePeriodicDumpsForTesting() {
- disable_periodic_dumps_for_testing_ = true;
- }
-
private:
friend struct DefaultDeleter<MemoryDumpManager>; // For the testing instance.
friend struct DefaultSingletonTraits<MemoryDumpManager>;
@@ -233,11 +228,6 @@ class BASE_EXPORT MemoryDumpManager : public TraceLog::EnabledStateObserver {
// Skips the auto-registration of the core dumpers during Initialize().
bool skip_core_dumpers_auto_registration_for_testing_;
- // When true, the initialization phase does not start the periodic memory
- // dumps.
- // TODO(primiano): This should go into TraceConfig. https://goo.gl/5Hj3o0.
- bool disable_periodic_dumps_for_testing_;
-
DISALLOW_COPY_AND_ASSIGN(MemoryDumpManager);
};
« no previous file with comments | « base/trace_event/BUILD.gn ('k') | base/trace_event/memory_dump_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698