Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Issue 1335503003: [tracing] Add test for memory-infra startup tracing (Closed)

Created:
5 years, 3 months ago by Primiano Tucci (use gerrit)
Modified:
5 years, 3 months ago
Reviewers:
Zhen Wang, dsinclair
CC:
chromium-reviews, tracing+reviews_chromium.org, wfh+watch_chromium.org, ssid
Base URL:
https://chromium.googlesource.com/chromium/src.git@startup_tracing
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[tracing] Add test for memory-infra startup tracing This is a follow-up to crrev.com/1333873002 that introduced support to startup tracing. Also this change refactors the TraceConfig JSON used by various memory-infra tests (in and out of base) into a test_util.h file. Furthermore this change fixes a off-by-one mistake in the periodic scheduler (and its test). BUG=524057 Committed: https://crrev.com/26b6f415865b7eab46b099d5773fbc0cb9e98b77 Cr-Commit-Position: refs/heads/master@{#348373}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Update build files #

Total comments: 2

Patch Set 4 : Nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+156 lines, -88 lines) Patch
M base/trace_event/BUILD.gn View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M base/trace_event/memory_dump_manager.h View 1 2 chunks +0 lines, -10 lines 0 comments Download
M base/trace_event/memory_dump_manager.cc View 1 3 chunks +3 lines, -6 lines 0 comments Download
M base/trace_event/memory_dump_manager_unittest.cc View 1 2 3 9 chunks +59 lines, -21 lines 0 comments Download
M base/trace_event/trace_config.h View 1 1 chunk +1 line, -1 line 0 comments Download
A base/trace_event/trace_config_memory_test_util.h View 1 1 chunk +76 lines, -0 lines 0 comments Download
M base/trace_event/trace_config_unittest.cc View 1 4 chunks +9 lines, -44 lines 0 comments Download
M base/trace_event/trace_event.gypi View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/tracing/memory_tracing_browsertest.cc View 1 3 chunks +6 lines, -6 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 10 (3 generated)
Primiano Tucci (use gerrit)
+dsinclair zhenw, mind if do some very small refactoring in trace_config_unittest? I need those memory-infra ...
5 years, 3 months ago (2015-09-10 16:09:07 UTC) #2
dsinclair
lgtm w/ nit. https://codereview.chromium.org/1335503003/diff/40001/base/trace_event/memory_dump_manager_unittest.cc File base/trace_event/memory_dump_manager_unittest.cc (right): https://codereview.chromium.org/1335503003/diff/40001/base/trace_event/memory_dump_manager_unittest.cc#newcode587 base/trace_event/memory_dump_manager_unittest.cc:587: // being, it will still late-join ...
5 years, 3 months ago (2015-09-10 16:43:46 UTC) #3
Primiano Tucci (use gerrit)
https://codereview.chromium.org/1335503003/diff/40001/base/trace_event/memory_dump_manager_unittest.cc File base/trace_event/memory_dump_manager_unittest.cc (right): https://codereview.chromium.org/1335503003/diff/40001/base/trace_event/memory_dump_manager_unittest.cc#newcode587 base/trace_event/memory_dump_manager_unittest.cc:587: // being, it will still late-join the party (real ...
5 years, 3 months ago (2015-09-10 17:01:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1335503003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1335503003/60001
5 years, 3 months ago (2015-09-11 09:49:25 UTC) #7
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 3 months ago (2015-09-11 11:04:51 UTC) #8
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/26b6f415865b7eab46b099d5773fbc0cb9e98b77 Cr-Commit-Position: refs/heads/master@{#348373}
5 years, 3 months ago (2015-09-11 11:05:31 UTC) #9
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:21:11 UTC) #10
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/26b6f415865b7eab46b099d5773fbc0cb9e98b77
Cr-Commit-Position: refs/heads/master@{#348373}

Powered by Google App Engine
This is Rietveld 408576698