| OLD | NEW |
| 1 Breakpad is a set of client and server components which implement a | 1 Breakpad is a set of client and server components which implement a |
| 2 crash-reporting system. | 2 crash-reporting system. |
| 3 | 3 |
| 4 | 4 |
| 5 ----- | 5 ----- |
| 6 Getting started in 32-bit mode (from trunk) | 6 Getting started in 32-bit mode (from trunk) |
| 7 Configure: CXXFLAGS=-m32 CFLAGS=-m32 CPPFLAGS=-m32 ./configure | 7 Configure: CXXFLAGS=-m32 CFLAGS=-m32 CPPFLAGS=-m32 ./configure |
| 8 Build: make | 8 Build: make |
| 9 Test: make check | 9 Test: make check |
| 10 Install: make install | 10 Install: make install |
| 11 | 11 |
| 12 If you need to reconfigure your build be sure to run "make distclean" first. | 12 If you need to reconfigure your build be sure to run "make distclean" first. |
| 13 | 13 |
| 14 | 14 |
| 15 ----- | 15 ----- |
| 16 To request change review: | 16 To request change review: |
| 17 0. Get access to a read-write copy of source. | 17 0. Get a copy of depot_tools repo. |
| 18 Owners at http://code.google.com/p/google-breakpad/ are able to grant | 18 http://dev.chromium.org/developers/how-tos/install-depot-tools |
| 19 this access. | |
| 20 | 19 |
| 21 1. Check out a read-write copy of source using instructions at | 20 1. Create a new directory for checking out the source code. |
| 22 http://code.google.com/p/google-breakpad/source/checkout | 21 mkdir breakpad && cd breakpad |
| 23 | 22 |
| 24 2. Make changes. Build and test your changes. | 23 2. Run the `fetch` tool from depot_tools to download all the source repos. |
| 24 fetch breakpad |
| 25 |
| 26 3. Make changes. Build and test your changes. |
| 25 For core code like processor use methods above. | 27 For core code like processor use methods above. |
| 26 For linux/mac/windows, there are test targets in each project file. | 28 For linux/mac/windows, there are test targets in each project file. |
| 27 | 29 |
| 28 3. Download http://codereview.appspot.com/static/upload.py | 30 4. Commit your changes to your local repo and upload them to the server. |
| 29 | 31 http://dev.chromium.org/developers/contributing-code |
| 30 4. Run upload.py from the 'src' directory: | 32 e.g. git commit ... && git cl upload ... |
| 31 upload.py --server=codereview.chromium.org | |
| 32 | |
| 33 You will be prompted for credential and a description. | 33 You will be prompted for credential and a description. |
| 34 | 34 |
| 35 5. At http://breakpad.appspot.com you'll find your issue listed; click on it, | 35 5. At https://codereview.chromium.org/ you'll find your issue listed; click on |
| 36 and select Publish+Mail, and enter in the code reviewer and CC | 36 it, and select Publish+Mail, and enter in the code reviewer and CC |
| 37 google-breakpad-dev@googlegroups.com | 37 google-breakpad-dev@googlegroups.com |
| 38 | |
| 39 6. When applying code review feedback, specify the '-i' option when running | |
| 40 upload.py again and pass the issue number so it updates the existing issue, | |
| 41 rather than creating a new one. | |
| 42 Be sure to rerun upload.py from the same directory as you did for previous | |
| 43 uploads to allow for proper diff calculations. | |
| OLD | NEW |