Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 1335453002: X87: [calls] Consistent call protocol for calls. (Closed)

Created:
5 years, 3 months ago by chunyang.dai
Modified:
5 years, 3 months ago
Reviewers:
Weiliang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [calls] Consistent call protocol for calls. port b37907ff7f866873ddfbfc97670b43c19a5fc7f9 (r30648). original commit message: The number of actual arguments should always be available, there's no point in trying to optimize away a simple assignment of an immediate to a register before some calls. The main motivation is to have a consistent state at the beginning of every function. Currently the arguments register (i.e. rax or eax) either contains the number of arguments or some random garbage depending on whether the callsite decided that the callee might need the information or not. This causes trouble with runtime implementations of functions that do not set internal_formal_parameter_count to the DontAdaptArguments sentinel (we don't have any of those yet), but also makes it impossible to sanity check the arguments in the callee, because the callee doesn't know whether the caller decided to pass the number of arguments or random garbage. BUG= Committed: https://crrev.com/99f0130782a57a9abcaea7da5f2a495fe3cb2071 Cr-Commit-Position: refs/heads/master@{#30669}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -10 lines) Patch
M src/x87/lithium-codegen-x87.cc View 2 chunks +3 lines, -8 lines 0 comments Download
M src/x87/macro-assembler-x87.cc View 3 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
chunyang.dai
PTAL
5 years, 3 months ago (2015-09-10 03:40:52 UTC) #2
Weiliang
lgtm
5 years, 3 months ago (2015-09-10 05:14:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1335453002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1335453002/1
5 years, 3 months ago (2015-09-10 05:14:22 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-10 05:42:45 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-10 05:43:02 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/99f0130782a57a9abcaea7da5f2a495fe3cb2071
Cr-Commit-Position: refs/heads/master@{#30669}

Powered by Google App Engine
This is Rietveld 408576698