Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1335423002: net: Remove 'libevent' from filenames. (Closed)

Created:
5 years, 3 months ago by tfarina
Modified:
5 years, 3 months ago
Reviewers:
mmenke
CC:
chromium-reviews, cbentzel+watch_chromium.org, szym, Deprecated (see juliatuttle)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

net: Remove 'libevent' from filenames. This patch removes 'libevent' from these filenames because they are not using libevent library anymore. BUG=None TEST=net_unittests R=mmenke@chromium.org Committed: https://crrev.com/4eb7aad877a19d57c9b420372b561e48e4855af3 Cr-Commit-Position: refs/heads/master@{#348637}

Patch Set 1 #

Patch Set 2 : socket_posix #

Patch Set 3 : tcp_socket_posix #

Patch Set 4 : UDPSocketLibevent -> UDPSocketPosix #

Patch Set 5 : TCPSocketLibevent -> TCPSocketPosix #

Patch Set 6 : SocketLibevent -> SocketPosix #

Total comments: 6

Patch Set 7 : review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+284 lines, -2977 lines) Patch
M net/BUILD.gn View 1 2 3 4 5 6 1 chunk +1 line, -9 lines 0 comments Download
M net/net.gypi View 1 2 3 4 5 6 13 chunks +22 lines, -22 lines 0 comments Download
M net/net_common.gypi View 1 2 3 4 5 6 1 chunk +0 lines, -6 lines 0 comments Download
D net/socket/socket_libevent.h View 1 1 chunk +0 lines, -132 lines 0 comments Download
D net/socket/socket_libevent.cc View 1 1 chunk +0 lines, -482 lines 0 comments Download
A + net/socket/socket_posix.h View 1 2 3 4 5 7 chunks +11 lines, -12 lines 0 comments Download
A + net/socket/socket_posix.cc View 1 2 3 4 5 26 chunks +43 lines, -44 lines 0 comments Download
M net/socket/tcp_socket.h View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
D net/socket/tcp_socket_libevent.h View 1 2 1 chunk +0 lines, -220 lines 0 comments Download
M net/socket/tcp_socket_libevent.cc View 1 2 1 chunk +0 lines, -774 lines 0 comments Download
A + net/socket/tcp_socket_posix.h View 1 2 3 4 5 6 chunks +15 lines, -15 lines 0 comments Download
A + net/socket/tcp_socket_posix.cc View 1 2 3 4 5 26 chunks +73 lines, -79 lines 0 comments Download
M net/socket/tcp_socket_win.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M net/socket/unix_domain_client_socket_posix.h View 1 2 3 4 5 6 3 chunks +4 lines, -4 lines 0 comments Download
M net/socket/unix_domain_client_socket_posix.cc View 1 2 3 4 5 3 chunks +4 lines, -7 lines 0 comments Download
M net/socket/unix_domain_client_socket_posix_unittest.cc View 1 2 3 4 5 4 chunks +4 lines, -4 lines 0 comments Download
M net/socket/unix_domain_server_socket_posix.h View 1 2 3 4 5 3 chunks +4 lines, -4 lines 0 comments Download
M net/socket/unix_domain_server_socket_posix.cc View 1 2 3 4 5 3 chunks +4 lines, -4 lines 0 comments Download
M net/test/embedded_test_server/stream_listen_socket.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M net/udp/udp_socket.h View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
D net/udp/udp_socket_libevent.h View 1 chunk +0 lines, -308 lines 0 comments Download
D net/udp/udp_socket_libevent.cc View 1 chunk +0 lines, -753 lines 0 comments Download
A + net/udp/udp_socket_posix.h View 1 2 3 7 chunks +15 lines, -15 lines 0 comments Download
A + net/udp/udp_socket_posix.cc View 1 2 3 32 chunks +78 lines, -77 lines 0 comments Download

Messages

Total messages: 9 (1 generated)
tfarina
PTAL
5 years, 3 months ago (2015-09-13 18:14:33 UTC) #1
mmenke
https://codereview.chromium.org/1335423002/diff/100001/net/BUILD.gn File net/BUILD.gn (right): https://codereview.chromium.org/1335423002/diff/100001/net/BUILD.gn#newcode347 net/BUILD.gn:347: ] With the posix suffix, we no longer need ...
5 years, 3 months ago (2015-09-14 15:12:45 UTC) #2
tfarina
https://codereview.chromium.org/1335423002/diff/100001/net/BUILD.gn File net/BUILD.gn (right): https://codereview.chromium.org/1335423002/diff/100001/net/BUILD.gn#newcode347 net/BUILD.gn:347: ] On 2015/09/14 15:12:44, mmenke wrote: > With the ...
5 years, 3 months ago (2015-09-14 15:46:02 UTC) #3
mmenke
LGTM!
5 years, 3 months ago (2015-09-14 15:48:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1335423002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1335423002/120001
5 years, 3 months ago (2015-09-14 16:52:30 UTC) #6
commit-bot: I haz the power
Committed patchset #7 (id:120001)
5 years, 3 months ago (2015-09-14 17:10:42 UTC) #7
commit-bot: I haz the power
Patchset 7 (id:??) landed as https://crrev.com/4eb7aad877a19d57c9b420372b561e48e4855af3 Cr-Commit-Position: refs/heads/master@{#348637}
5 years, 3 months ago (2015-09-14 17:11:56 UTC) #8
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:33:22 UTC) #9
Message was sent while issue was closed. 
Patchset 7 (id:??) landed as
https://crrev.com/4eb7aad877a19d57c9b420372b561e48e4855af3
Cr-Commit-Position: refs/heads/master@{#348637}

Powered by Google App Engine
This is Rietveld 408576698