Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 1335393002: Fix TRANSFORM_FEEDBACK_PRIMITIVES_WRITTEN query results. (Closed)

Created:
5 years, 3 months ago by Ken Russell (switch to Gerrit)
Modified:
5 years, 3 months ago
Reviewers:
Zhenyao Mo, David Yen, piman
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix TRANSFORM_FEEDBACK_PRIMITIVES_WRITTEN query results. They were being truncated to either 0 or 1. Explicitly handle ANY_SAMPLES_PASSED, ANY_SAMPLES_PASSED_CONSERVATIVE, and TRANSFORM_FEEDBACK_PRIMITIVES_WRITTEN BeginQuery targets. BUG=526748 Committed: https://crrev.com/2b3b21e2dc03cb47d27cfa92c0680d89e35e7262 Cr-Commit-Position: refs/heads/master@{#348698}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -23 lines) Patch
M gpu/command_buffer/service/query_manager.cc View 6 chunks +85 lines, -23 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
Ken Russell (switch to Gerrit)
Please review. Thanks. This has been tested with the ported dEQP transform feedback tests at ...
5 years, 3 months ago (2015-09-12 02:54:34 UTC) #2
David Yen
lgtm
5 years, 3 months ago (2015-09-14 16:23:05 UTC) #3
Zhenyao Mo
LGTM
5 years, 3 months ago (2015-09-14 17:00:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1335393002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1335393002/1
5 years, 3 months ago (2015-09-14 18:30:00 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-14 20:12:53 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/2b3b21e2dc03cb47d27cfa92c0680d89e35e7262 Cr-Commit-Position: refs/heads/master@{#348698}
5 years, 3 months ago (2015-09-14 20:13:39 UTC) #8
piman
lgtm
5 years, 3 months ago (2015-09-14 20:22:05 UTC) #9
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:36:27 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2b3b21e2dc03cb47d27cfa92c0680d89e35e7262
Cr-Commit-Position: refs/heads/master@{#348698}

Powered by Google App Engine
This is Rietveld 408576698