Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 1335373003: Have a Page's MemoryPurgeController be a separate allocation also. (Closed)

Created:
5 years, 3 months ago by sof
Modified:
5 years, 3 months ago
Reviewers:
haraken, bashi
CC:
blink-reviews
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Have a Page's MemoryPurgeController be a separate allocation also. A Page keeps and owns a number of controllers, each being separately allocated. Extend that to also apply to MemoryPurgeController; it is created on demand, and no longer a part object. R=haraken BUG=520496 Committed: https://crrev.com/c6dad2677039627a2ddc5666182565d82201163e git-svn-id: svn://svn.chromium.org/blink/trunk@202261 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -6 lines) Patch
M Source/core/page/Page.h View 4 chunks +3 lines, -3 lines 0 comments Download
M Source/core/page/Page.cpp View 3 chunks +10 lines, -1 line 0 comments Download
M Source/platform/MemoryPurgeController.h View 2 chunks +8 lines, -2 lines 0 comments Download
M Source/platform/MemoryPurgeController.cpp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
sof
please take a look. not much in this one, but I think it is slightly ...
5 years, 3 months ago (2015-09-15 06:17:03 UTC) #2
haraken
LGTM
5 years, 3 months ago (2015-09-15 06:20:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1335373003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1335373003/1
5 years, 3 months ago (2015-09-15 06:43:13 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=202261
5 years, 3 months ago (2015-09-15 07:15:45 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:43:08 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c6dad2677039627a2ddc5666182565d82201163e

Powered by Google App Engine
This is Rietveld 408576698