Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Side by Side Diff: client/capture_context_mac_test.cc

Issue 1335353002: Replace implicit_cast usage with static_cast. (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: implicitcast: fixes Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Crashpad Authors. All rights reserved. 1 // Copyright 2014 The Crashpad Authors. All rights reserved.
2 // 2 //
3 // Licensed under the Apache License, Version 2.0 (the "License"); 3 // Licensed under the Apache License, Version 2.0 (the "License");
4 // you may not use this file except in compliance with the License. 4 // you may not use this file except in compliance with the License.
5 // You may obtain a copy of the License at 5 // You may obtain a copy of the License at
6 // 6 //
7 // http://www.apache.org/licenses/LICENSE-2.0 7 // http://www.apache.org/licenses/LICENSE-2.0
8 // 8 //
9 // Unless required by applicable law or agreed to in writing, software 9 // Unless required by applicable law or agreed to in writing, software
10 // distributed under the License is distributed on an "AS IS" BASIS, 10 // distributed under the License is distributed on an "AS IS" BASIS,
11 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. 11 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12 // See the License for the specific language governing permissions and 12 // See the License for the specific language governing permissions and
13 // limitations under the License. 13 // limitations under the License.
14 14
15 #include "client/capture_context_mac.h" 15 #include "client/capture_context_mac.h"
16 16
17 #include <mach/mach.h> 17 #include <mach/mach.h>
18 #include <stdint.h> 18 #include <stdint.h>
19 19
20 #include <algorithm> 20 #include <algorithm>
21 21
22 #include "base/basictypes.h" 22 #include "base/basictypes.h"
Mark Mentovai 2015/09/12 00:15:14 Drop this.
danakj 2015/09/12 00:17:47 Done.
23 #include "build/build_config.h" 23 #include "build/build_config.h"
24 #include "gtest/gtest.h" 24 #include "gtest/gtest.h"
25 #include "util/misc/implicit_cast.h"
25 26
26 namespace crashpad { 27 namespace crashpad {
27 namespace test { 28 namespace test {
28 namespace { 29 namespace {
29 30
30 // If the context structure has fields that tell whether it’s valid, such as 31 // If the context structure has fields that tell whether it’s valid, such as
31 // magic numbers or size fields, sanity-checks those fields for validity with 32 // magic numbers or size fields, sanity-checks those fields for validity with
32 // fatal gtest assertions. For other fields, where it’s possible to reason about 33 // fatal gtest assertions. For other fields, where it’s possible to reason about
33 // their validity based solely on their contents, sanity-checks via nonfatal 34 // their validity based solely on their contents, sanity-checks via nonfatal
34 // gtest assertions. 35 // gtest assertions.
(...skipping 108 matching lines...) Expand 10 before | Expand all | Expand 10 after
143 EXPECT_GT(ProgramCounterFromContext(&context_2), pc); 144 EXPECT_GT(ProgramCounterFromContext(&context_2), pc);
144 } 145 }
145 146
146 TEST(CaptureContextMac, CaptureContext) { 147 TEST(CaptureContextMac, CaptureContext) {
147 ASSERT_NO_FATAL_FAILURE(TestCaptureContext()); 148 ASSERT_NO_FATAL_FAILURE(TestCaptureContext());
148 } 149 }
149 150
150 } // namespace 151 } // namespace
151 } // namespace test 152 } // namespace test
152 } // namespace crashpad 153 } // namespace crashpad
OLDNEW
« no previous file with comments | « no previous file | client/simple_string_dictionary.h » ('j') | minidump/test/minidump_writable_test_util.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698