Replace implicit_cast usage with static_cast.

Replace implicit_cast usage with static_cast.

chromium's implicit_cast is going to be removed so stop using it.

BUG=529769, 472900
R=mark@chromium.org

Committed: https://chromium.googlesource.com/crashpad/crashpad/+/5069c2903a1be6e717c526595c85f8736033e5e8

[danakj, 2015-09-11 23:21:58]

Chromium side this depends on is here:
https://codereview.chromium.org/1340683002/

[danakj, 2015-09-11 23:22:57]

danakj@chromium.org changed reviewers:
+ rsesek@chromium.org, scottmg@chromium.org

[danakj, 2015-09-11 23:22:57]

Hey could one of y'all review this? Thanks!

[Mark Mentovai, 2015-09-11 23:25:56]

I kind of like implicit_cast, maybe we keep it in crashpad/util.

[danakj, 2015-09-11 23:26:15]

On 2015/09/11 23:25:56, Mark Mentovai - August is over wrote:
> I kind of like implicit_cast, maybe we keep it in crashpad/util.

ya sure. I can do that

[danakj, 2015-09-11 23:33:39]

PTAL

btw apparently crashpad is not allowed to use base like this?

http://crbug.com/468375 is similar.

[scottmg, 2015-09-11 23:35:00]

On 2015/09/11 23:33:39, danakj wrote:
> PTAL
> 
> btw apparently crashpad is not allowed to use base like this?
> 
> http://crbug.com/468375 is similar.

We have an open bug for that, but it hasn't been addressed yet:
https://code.google.com/p/chromium/issues/detail?id=472900

[danakj, 2015-09-11 23:35:46]

On 2015/09/11 23:33:39, danakj wrote:
> PTAL
> 
> btw apparently crashpad is not allowed to use base like this?
> 
> http://crbug.com/468375 is similar.

Perhaps you need to put mini_chromium somewhere other than at the root, and
include in src/third_party/crashpad or something, so that "base/..." does not
point at actual base when building in chromium.

[danakj, 2015-09-11 23:41:22]

On 2015/09/11 23:35:00, scottmg wrote:
> On 2015/09/11 23:33:39, danakj wrote:
> > PTAL
> > 
> > btw apparently crashpad is not allowed to use base like this?
> > 
> > http://crbug.com/468375 is similar.
> 
> We have an open bug for that, but it hasn't been addressed yet:
> https://code.google.com/p/chromium/issues/detail?id=472900

Thanks.

BTW I want to build and test this patch but I get all kinds of warnings as
errors when I build using the instructions on the page. Stuff like:

../../util/misc/pdb_structures.h:43:38: error: multi-character character
constant [-Werror=multichar]
   static const uint32_t kSignature = '01BN';
                                      ^
So I'm not sure how to verify this builds.

[scottmg, 2015-09-11 23:47:52]

On 2015/09/11 23:41:22, danakj wrote:
> On 2015/09/11 23:35:00, scottmg wrote:
> > On 2015/09/11 23:33:39, danakj wrote:
> > > PTAL
> > > 
> > > btw apparently crashpad is not allowed to use base like this?
> > > 
> > > http://crbug.com/468375 is similar.
> > 
> > We have an open bug for that, but it hasn't been addressed yet:
> > https://code.google.com/p/chromium/issues/detail?id=472900
> 
> Thanks.
> 
> BTW I want to build and test this patch but I get all kinds of warnings as
> errors when I build using the instructions on the page. Stuff like:
> 
> ../../util/misc/pdb_structures.h:43:38: error: multi-character character
> constant [-Werror=multichar]
>    static const uint32_t kSignature = '01BN';
>                                       ^
> So I'm not sure how to verify this builds.

What platform are you building on?

[scottmg, 2015-09-11 23:57:34]

https://codereview.chromium.org/1335353002/diff/20001/util/misc/implicit_cast.h
File util/misc/implicit_cast.h (right):

https://codereview.chromium.org/1335353002/diff/20001/util/misc/implicit_cast...
util/misc/implicit_cast.h:1: // Copyright 2015 The Crashpad Authors. All rights
reserved.
Needs to be added to util/util.gyp.

https://codereview.chromium.org/1335353002/diff/20001/util/misc/implicit_cast...
util/misc/implicit_cast.h:15: namespace crashpad {
This file needs header guards.

[Mark Mentovai, 2015-09-12 00:07:19]

danakj wrote:
> On 2015/09/11 23:33:39, danakj wrote:
> > PTAL
> > 
> > btw apparently crashpad is not allowed to use base like this?
> > 
> > http://crbug.com/468375 is similar.
> 
> Perhaps you need to put mini_chromium somewhere other than at the root, and
> include in src/third_party/crashpad or something, so that "base/..." does not
> point at actual base when building in chromium.

We’re not using mini_chromium’s base for the in-Chromium build, we’re using
Chromium’s base. (Otherwise, ODR and bloat…)

[danakj, 2015-09-12 00:10:58]

Thanks, PTAL

https://codereview.chromium.org/1335353002/diff/20001/util/misc/implicit_cast.h
File util/misc/implicit_cast.h (right):

https://codereview.chromium.org/1335353002/diff/20001/util/misc/implicit_cast...
util/misc/implicit_cast.h:1: // Copyright 2015 The Crashpad Authors. All rights
reserved.
On 2015/09/11 23:57:34, scottmg wrote:
> Needs to be added to util/util.gyp.

Done.

https://codereview.chromium.org/1335353002/diff/20001/util/misc/implicit_cast...
util/misc/implicit_cast.h:15: namespace crashpad {
On 2015/09/11 23:57:34, scottmg wrote:
> This file needs header guards.

Oops. Done.

[Mark Mentovai, 2015-09-12 00:15:14]

mark@chromium.org changed reviewers:
+ mark@chromium.org

[Mark Mentovai, 2015-09-12 00:15:15]

https://codereview.chromium.org/1335353002/diff/40001/client/capture_context_...
File client/capture_context_mac_test.cc (right):

https://codereview.chromium.org/1335353002/diff/40001/client/capture_context_...
client/capture_context_mac_test.cc:22: #include "base/basictypes.h"
Drop this.

https://codereview.chromium.org/1335353002/diff/40001/minidump/test/minidump_...
File minidump/test/minidump_writable_test_util.cc (right):

https://codereview.chromium.org/1335353002/diff/40001/minidump/test/minidump_...
minidump/test/minidump_writable_test_util.cc:19: #include "base/basictypes.h"
And this.

[danakj, 2015-09-12 00:17:47]

Thanks, PTAL

https://codereview.chromium.org/1335353002/diff/40001/client/capture_context_...
File client/capture_context_mac_test.cc (right):

https://codereview.chromium.org/1335353002/diff/40001/client/capture_context_...
client/capture_context_mac_test.cc:22: #include "base/basictypes.h"
On 2015/09/12 00:15:14, Mark Mentovai - August is over wrote:
> Drop this.

Done.

https://codereview.chromium.org/1335353002/diff/40001/minidump/test/minidump_...
File minidump/test/minidump_writable_test_util.cc (right):

https://codereview.chromium.org/1335353002/diff/40001/minidump/test/minidump_...
minidump/test/minidump_writable_test_util.cc:19: #include "base/basictypes.h"
On 2015/09/12 00:15:14, Mark Mentovai - August is over wrote:
> And this.

Done.

[Mark Mentovai, 2015-09-12 00:24:37]

LGTM

[scottmg, 2015-09-14 18:05:18]

Dana, do you want me to land this?

[scottmg, 2015-09-14 18:09:50]

Committed patchset #4 (id:60001) manually as
5069c2903a1be6e717c526595c85f8736033e5e8 (presubmit successful).