Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 133533007: Mojo: Move PlatformChannelPair to its own files. (Closed)

Created:
6 years, 11 months ago by viettrungluu
Modified:
6 years, 11 months ago
CC:
chromium-reviews, Aaron Boodman, darin (slow to review), viettrungluu+watch_chromium.org, ben+mojo_chromium.org, abarth-chromium
Visibility:
Public.

Description

Mojo: Move PlatformChannelPair to its own files. (platform_channel_posix.cc gets moved to platform_channel_pair_posix.cc entirely.) R=darin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244234

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -254 lines) Patch
M mojo/common/test/multiprocess_test_base.h View 1 chunk +6 lines, -1 line 0 comments Download
M mojo/common/test/multiprocess_test_base.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M mojo/common/test/multiprocess_test_base_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/mojo.gyp View 1 chunk +3 lines, -1 line 0 comments Download
M mojo/system/platform_channel.h View 2 chunks +1 line, -57 lines 0 comments Download
M mojo/system/platform_channel.cc View 1 chunk +0 lines, -31 lines 0 comments Download
A + mojo/system/platform_channel_pair.h View 3 chunks +6 lines, -29 lines 0 comments Download
A + mojo/system/platform_channel_pair.cc View 1 chunk +3 lines, -27 lines 0 comments Download
A + mojo/system/platform_channel_pair_posix.cc View 2 chunks +3 lines, -2 lines 0 comments Download
D mojo/system/platform_channel_posix.cc View 1 chunk +0 lines, -106 lines 0 comments Download
M mojo/system/raw_channel_posix_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/system/remote_message_pipe_posix_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
viettrungluu
6 years, 11 months ago (2014-01-10 20:18:04 UTC) #1
darin (slow to review)
LGTM
6 years, 11 months ago (2014-01-10 20:19:28 UTC) #2
viettrungluu
6 years, 11 months ago (2014-01-10 20:50:28 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r244234 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698