Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 1335313003: Replace instances of datadeps --> data_deps. (Closed)

Created:
5 years, 3 months ago by eroman
Modified:
5 years, 3 months ago
Reviewers:
brettw
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, tfarina, jam, Bons, jbudorick+watch_chromium.org, eme-reviews_chromium.org, darin-cc_chromium.org, yfriedman+watch_chromium.org, nodir, mkwst+moarreviews-shell_chromium.org, klundberg+watch_chromium.org, jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace instances of datadeps --> data_deps. The latter is the canonical name, however both are supported. TBR=xhwang@chromium.org, mkwst@chromium.org Committed: https://crrev.com/3cb0032bded7ce5127f489593928b830bfe8f29b Cr-Commit-Position: refs/heads/master@{#348825}

Patch Set 1 #

Total comments: 1

Patch Set 2 : rebase #

Patch Set 3 : make formatter recognize both datadeps and data_deps #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -22 lines) Patch
M content/shell/BUILD.gn View 2 chunks +2 lines, -6 lines 0 comments Download
M third_party/widevine/cdm/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M tools/android/forwarder2/BUILD.gn View 2 chunks +2 lines, -4 lines 0 comments Download
M tools/android/md5sum/BUILD.gn View 1 chunk +3 lines, -3 lines 0 comments Download
M tools/gn/command_format.cc View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M tools/gn/docs/language.md View 1 2 chunks +2 lines, -2 lines 0 comments Download
M tools/gn/docs/reference.md View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/variables.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
eroman
I figure this is desired, but I may have misread things. https://codereview.chromium.org/1335313003/diff/1/tools/gn/command_format.cc File tools/gn/command_format.cc (right): ...
5 years, 3 months ago (2015-09-12 00:35:46 UTC) #2
brettw
lgtm
5 years, 3 months ago (2015-09-12 02:06:48 UTC) #3
eroman
I made an additional change to the formatter: https://codereview.chromium.org/1335313003/diff2/20001:40001/tools/gn/command_format.cc (To avoid changing any test data).
5 years, 3 months ago (2015-09-14 21:57:27 UTC) #4
eroman
+TBR xhwang, mkwst: xhwang: third_party/widevine/cdm/BUILD.gn mkwst: content/shell/BUILD.gn
5 years, 3 months ago (2015-09-15 02:37:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1335313003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1335313003/40001
5 years, 3 months ago (2015-09-15 02:38:04 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 3 months ago (2015-09-15 02:42:28 UTC) #9
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/3cb0032bded7ce5127f489593928b830bfe8f29b Cr-Commit-Position: refs/heads/master@{#348825}
5 years, 3 months ago (2015-09-15 02:43:01 UTC) #10
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:42:02 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/3cb0032bded7ce5127f489593928b830bfe8f29b
Cr-Commit-Position: refs/heads/master@{#348825}

Powered by Google App Engine
This is Rietveld 408576698