Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 1335303002: Add (back) assignment operator overloads over Persistent<> types. (Closed)

Created:
5 years, 3 months ago by sof
Modified:
5 years, 3 months ago
Reviewers:
oilpan-reviews, haraken
CC:
blink-reviews, oilpan-reviews, kouhei+heap_chromium.org, Mads Ager (chromium)
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Add (back) assignment operator overloads over Persistent<> types. Overloads aren't inherited, so add the required delegating operator= overload implementation for (CrossThread)(Weak)Persistent<> types. Without these, an assignment like V :: Persistent<T> X :: RawPtr<T> V = X; will be desugared & compiled as V = Persistent<T>(X); // where "=" is the copy constructor. i.e., introducing (and allocating) a temporary Persistent<> for the RHS. (This assignment shows up when initializing a WebPrivatePtr<T> over a GCed type T, for instance.) R=haraken BUG=420515 Committed: https://crrev.com/ca262b0755f50b738722c5857973a5535b7d1afe git-svn-id: svn://svn.chromium.org/blink/trunk@202191 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Patch Set 1 #

Total comments: 1

Patch Set 2 : remove erroneous parameterization of operator=(std::nullptr_t)s #

Unified diffs Side-by-side diffs Delta from patch set Stats (+160 lines, -0 lines) Patch
M Source/platform/heap/Handle.h View 1 4 chunks +160 lines, -0 lines 0 comments Download

Messages

Total messages: 36 (17 generated)
sof
please take a look.
5 years, 3 months ago (2015-09-11 20:58:08 UTC) #2
haraken
LGTM
5 years, 3 months ago (2015-09-12 03:31:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1335303002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1335303002/1
5 years, 3 months ago (2015-09-12 05:41:50 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_rel/builds/133132)
5 years, 3 months ago (2015-09-12 11:14:36 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1335303002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1335303002/1
5 years, 3 months ago (2015-09-12 14:39:51 UTC) #9
sof
https://codereview.chromium.org/1335303002/diff/1/Source/platform/heap/Handle.h File Source/platform/heap/Handle.h (right): https://codereview.chromium.org/1335303002/diff/1/Source/platform/heap/Handle.h#newcode299 Source/platform/heap/Handle.h:299: template<typename U> Cut&paste error - this one shouldn't be ...
5 years, 3 months ago (2015-09-12 17:26:17 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1335303002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1335303002/20001
5 years, 3 months ago (2015-09-12 20:59:41 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/103225)
5 years, 3 months ago (2015-09-12 23:05:44 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1335303002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1335303002/20001
5 years, 3 months ago (2015-09-13 05:42:17 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_rel/builds/133148)
5 years, 3 months ago (2015-09-13 11:15:37 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1335303002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1335303002/20001
5 years, 3 months ago (2015-09-13 11:40:48 UTC) #22
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_clobber_rel_ng/builds/69180)
5 years, 3 months ago (2015-09-13 14:43:16 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1335303002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1335303002/20001
5 years, 3 months ago (2015-09-13 14:48:42 UTC) #26
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_clobber_rel_ng/builds/69204)
5 years, 3 months ago (2015-09-13 20:49:19 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1335303002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1335303002/20001
5 years, 3 months ago (2015-09-14 05:11:19 UTC) #30
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_chromium_compile_only_ng/builds/31693)
5 years, 3 months ago (2015-09-14 05:34:33 UTC) #32
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1335303002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1335303002/20001
5 years, 3 months ago (2015-09-14 06:51:51 UTC) #34
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://src.chromium.org/viewvc/blink?view=rev&revision=202191
5 years, 3 months ago (2015-09-14 08:20:41 UTC) #35
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:30:49 UTC) #36
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ca262b0755f50b738722c5857973a5535b7d1afe

Powered by Google App Engine
This is Rietveld 408576698