|
|
Created:
5 years, 3 months ago by sof Modified:
5 years, 3 months ago CC:
blink-reviews, oilpan-reviews, kouhei+heap_chromium.org, Mads Ager (chromium) Base URL:
svn://svn.chromium.org/blink/trunk Target Ref:
refs/heads/master Project:
blink Visibility:
Public. |
DescriptionAdd (back) assignment operator overloads over Persistent<> types.
Overloads aren't inherited, so add the required delegating operator=
overload implementation for (CrossThread)(Weak)Persistent<> types.
Without these, an assignment like
V :: Persistent<T>
X :: RawPtr<T>
V = X;
will be desugared & compiled as
V = Persistent<T>(X); // where "=" is the copy constructor.
i.e., introducing (and allocating) a temporary Persistent<> for the RHS.
(This assignment shows up when initializing a WebPrivatePtr<T> over a GCed
type T, for instance.)
R=haraken
BUG=420515
Committed: https://crrev.com/ca262b0755f50b738722c5857973a5535b7d1afe
git-svn-id: svn://svn.chromium.org/blink/trunk@202191 bbb929c8-8fbe-4397-9dbb-9b2b20218538
Patch Set 1 #
Total comments: 1
Patch Set 2 : remove erroneous parameterization of operator=(std::nullptr_t)s #Messages
Total messages: 36 (17 generated)
sigbjornf@opera.com changed reviewers: + oilpan-reviews@chromium.org
please take a look.
LGTM
The CQ bit was checked by sigbjornf@opera.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1335303002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1335303002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by sigbjornf@opera.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1335303002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1335303002/1
The CQ bit was unchecked by sigbjornf@opera.com
https://codereview.chromium.org/1335303002/diff/1/Source/platform/heap/Handle.h File Source/platform/heap/Handle.h (right): https://codereview.chromium.org/1335303002/diff/1/Source/platform/heap/Handle... Source/platform/heap/Handle.h:299: template<typename U> Cut&paste error - this one shouldn't be parameterized; will fix & pass along again.
The CQ bit was checked by sigbjornf@opera.com
The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org Link to the patchset: https://codereview.chromium.org/1335303002/#ps20001 (title: "remove erroneous parameterization of operator=(std::nullptr_t)s")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1335303002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1335303002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by sigbjornf@opera.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1335303002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1335303002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by sigbjornf@opera.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1335303002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1335303002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by sigbjornf@opera.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1335303002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1335303002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by sigbjornf@opera.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1335303002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1335303002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
The CQ bit was checked by sigbjornf@opera.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1335303002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1335303002/20001
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://src.chromium.org/viewvc/blink?view=rev&revision=202191
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/ca262b0755f50b738722c5857973a5535b7d1afe |