Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 1335213004: [CSS Grid Layout] Content sized tracks must clear the override height (Closed)

Created:
5 years, 3 months ago by jfernandez
Modified:
5 years, 3 months ago
CC:
blink-reviews, jfernandez, szager+layoutwatch_chromium.org, zoltan1, pdr+renderingwatchlist_chromium.org, Manuel Rego, leviw+renderwatch, blink-reviews-rendering, jchaffraix+rendering, eae+blinkwatch
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[CSS Grid Layout] Content sized tracks must clear the override height Content sized tracks depend on grid item's height to determine their height. If the item was stretched and needs a new layout, we must clear the override height to properly. However, we can't just clear the override height because we need to know it was set, hence we would need grid item's intrinsic height instead of its logicalHeight in case it does not need such new layout. BUG=530476 Committed: https://crrev.com/1933e54a3be88efa7e4f71d0fd05f1a459a35b72 git-svn-id: svn://svn.chromium.org/blink/trunk@202196 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -7 lines) Patch
M LayoutTests/fast/css-grid-layout/grid-items-should-not-be-stretched-when-height-or-width-or-margin-change.html View 3 chunks +35 lines, -4 lines 0 comments Download
M LayoutTests/fast/css-grid-layout/grid-items-should-not-be-stretched-when-height-or-width-or-margin-change-expected.txt View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/layout/LayoutGrid.cpp View 2 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
jfernandez
5 years, 3 months ago (2015-09-11 21:33:44 UTC) #2
svillar
The patch looks good but we need more tests. The description mentions content sized tracks ...
5 years, 3 months ago (2015-09-14 07:05:06 UTC) #3
svillar
On 2015/09/14 07:05:06, svillar wrote: > The patch looks good but we need more tests. ...
5 years, 3 months ago (2015-09-14 07:07:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1335213004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1335213004/1
5 years, 3 months ago (2015-09-14 10:40:20 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=202196
5 years, 3 months ago (2015-09-14 11:53:32 UTC) #7
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:31:41 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1933e54a3be88efa7e4f71d0fd05f1a459a35b72

Powered by Google App Engine
This is Rietveld 408576698