Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issue 1335213002: [Sync] Remove LimitSyncPassphrasePrompt experiment check from PSSA. (Closed)

Created:
5 years, 3 months ago by maxbogue
Modified:
5 years, 3 months ago
Reviewers:
Nicolas Zea
CC:
chromium-reviews, tim+watch_chromium.org, pvalenzuela+watch_chromium.org, maxbogue+watch_chromium.org, plaree+watch_chromium.org, zea+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Sync] Remove LimitSyncPassphrasePrompt experiment check from PSSA. The experiment has been at 100% for a while without incident. BUG=497518 Committed: https://crrev.com/d811c1c7e09531d9fe0ed960e99070c24f134d05 Cr-Commit-Position: refs/heads/master@{#348704}

Patch Set 1 #

Patch Set 2 : Remove experiment entirely. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M chrome/browser/sync/profile_sync_service_android.cc View 2 chunks +0 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
maxbogue
Nicolas, PTAL. The other option for this would be moving the check into SyncPrefs itself, ...
5 years, 3 months ago (2015-09-11 18:14:32 UTC) #2
Nicolas Zea
I'm actually planning to remove the experiment altogether (and leave it on by default) at ...
5 years, 3 months ago (2015-09-11 20:49:57 UTC) #3
maxbogue
On 2015/09/11 20:49:57, Nicolas Zea wrote: > I'm actually planning to remove the experiment altogether ...
5 years, 3 months ago (2015-09-11 22:31:28 UTC) #4
Nicolas Zea
LGTM, thanks!
5 years, 3 months ago (2015-09-14 19:40:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1335213002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1335213002/20001
5 years, 3 months ago (2015-09-14 19:49:49 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-14 20:19:06 UTC) #8
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/d811c1c7e09531d9fe0ed960e99070c24f134d05 Cr-Commit-Position: refs/heads/master@{#348704}
5 years, 3 months ago (2015-09-14 20:19:42 UTC) #9
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:36:39 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d811c1c7e09531d9fe0ed960e99070c24f134d05
Cr-Commit-Position: refs/heads/master@{#348704}

Powered by Google App Engine
This is Rietveld 408576698