[builtins] Simplify String constructor code.

[builtins] Simplify String constructor code.

The String constructor was somewhat complex with a lot of micro
optimizations that are not relevant or even misguided. It would be
really hard to port that code to ES6, which requires String to be
subclassable. So as a first step we reduced the necessary complexity
to the bare minimum (also removing the last user of the fairly complex
MacroAssembler::LookupNumberStringCache method).

This also removes the counters for the String constructor, which
were not properly exposed anymore (and not kept in sync with inlined
versions of the String constructor anyway).

R=jarin@chromium.org

Committed: https://crrev.com/eadfd666318c1dd959d7fac7c27538ef478a8b72
Cr-Commit-Position: refs/heads/master@{#30706}

[Benedikt Meurer, 2015-09-14 05:45:43]

bmeurer@chromium.org changed reviewers:
+ jarin@chromium.org

[Benedikt Meurer, 2015-09-14 05:46:12]

Patchset #1 (id:1) has been deleted

[Benedikt Meurer, 2015-09-14 05:46:25]

The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-09-14 05:46:32]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1335193002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1335193002/20001

[Benedikt Meurer, 2015-09-14 05:46:50]

Hey Jaro,

Removing another ~800 lines of unnecessary complex native code.
Please take a look.

Thanks,
Benedikt

[commit-bot: I haz the power, 2015-09-14 05:54:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-14 05:54:14]

Dry run: Try jobs failed on following builders:
  v8_linux_mips64el_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_r...)

[Benedikt Meurer, 2015-09-14 06:15:43]

The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-09-14 06:15:56]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1335193002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1335193002/40001

[commit-bot: I haz the power, 2015-09-14 06:40:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-14 06:40:12]

Dry run: This issue passed the CQ dry run.

[Jarin, 2015-09-14 07:11:41]

lgtm with nits.

https://codereview.chromium.org/1335193002/diff/40001/src/arm/builtins-arm.cc
File src/arm/builtins-arm.cc (right):

https://codereview.chromium.org/1335193002/diff/40001/src/arm/builtins-arm.cc...
src/arm/builtins-arm.cc:178: __
LoadGlobalFunction(Context::STRING_FUNCTION_INDEX, r1);
Maybe some comment about the incoming r1 being the same as the context's string
constructor?

https://codereview.chromium.org/1335193002/diff/40001/src/mips64/builtins-mip...
File src/mips64/builtins-mips64.cc (right):

https://codereview.chromium.org/1335193002/diff/40001/src/mips64/builtins-mip...
src/mips64/builtins-mips64.cc:192: //  -- lr : return address
Why have you changed ra to lr here?

[Benedikt Meurer, 2015-09-14 07:26:34]

The CQ bit was checked by bmeurer@chromium.org

[Benedikt Meurer, 2015-09-14 07:26:34]

The patchset sent to the CQ was uploaded after l-g-t-m from jarin@chromium.org
Link to the patchset: https://codereview.chromium.org/1335193002/#ps60001
(title: "Address Jaro's comments.")

[Benedikt Meurer, 2015-09-14 07:26:40]

https://codereview.chromium.org/1335193002/diff/40001/src/arm/builtins-arm.cc
File src/arm/builtins-arm.cc (right):

https://codereview.chromium.org/1335193002/diff/40001/src/arm/builtins-arm.cc...
src/arm/builtins-arm.cc:178: __
LoadGlobalFunction(Context::STRING_FUNCTION_INDEX, r1);
On 2015/09/14 07:11:40, Jarin wrote:
> Maybe some comment about the incoming r1 being the same as the context's
string
> constructor?

Done.

https://codereview.chromium.org/1335193002/diff/40001/src/mips64/builtins-mip...
File src/mips64/builtins-mips64.cc (right):

https://codereview.chromium.org/1335193002/diff/40001/src/mips64/builtins-mip...
src/mips64/builtins-mips64.cc:192: //  -- lr : return address
On 2015/09/14 07:11:41, Jarin wrote:
> Why have you changed ra to lr here?

Done.

[commit-bot: I haz the power, 2015-09-14 07:26:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1335193002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1335193002/60001

[commit-bot: I haz the power, 2015-09-14 07:51:12]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2015-09-14 07:51:32]

Patchset 3 (id:??) landed as
https://crrev.com/eadfd666318c1dd959d7fac7c27538ef478a8b72
Cr-Commit-Position: refs/heads/master@{#30706}