Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(536)

Unified Diff: Source/core/css/parser/CSSPropertyParser.cpp

Issue 1335183002: Change CSSImageValue's member variables from String to AtomicString (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/css/parser/CSSPropertyParser.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/css/parser/CSSPropertyParser.cpp
diff --git a/Source/core/css/parser/CSSPropertyParser.cpp b/Source/core/css/parser/CSSPropertyParser.cpp
index 4ddccd5395483aec08c2bc01bb68c7d3250e60ba..0554cf6e27d5a60eed966b9df10aca0e53d7df95 100644
--- a/Source/core/css/parser/CSSPropertyParser.cpp
+++ b/Source/core/css/parser/CSSPropertyParser.cpp
@@ -314,7 +314,7 @@ inline PassRefPtrWillBeRawPtr<CSSPrimitiveValue> CSSPropertyParser::createPrimit
return cssValuePool().createValue(value->string, CSSPrimitiveValue::UnitType::CustomIdentifier);
}
-inline PassRefPtrWillBeRawPtr<CSSValue> CSSPropertyParser::createCSSImageValueWithReferrer(const String& rawValue, const KURL& url)
+inline PassRefPtrWillBeRawPtr<CSSValue> CSSPropertyParser::createCSSImageValueWithReferrer(const AtomicString& rawValue, const KURL& url)
{
RefPtrWillBeRawPtr<CSSValue> imageValue = CSSImageValue::create(rawValue, url);
toCSSImageValue(imageValue.get())->setReferrer(m_context.referrer());
@@ -593,7 +593,7 @@ bool CSSPropertyParser::parseValue(CSSPropertyID unresolvedProperty, bool import
if (value->unit() == CSSPrimitiveValue::UnitType::URI) {
String uri = value->string;
Timothy Loh 2015/09/18 01:52:30 I think this line does a conversion, might as well
hajimehoshi 2015/09/18 04:23:08 Done.
if (!uri.isNull())
- image = createCSSImageValueWithReferrer(uri, completeURL(uri));
+ image = createCSSImageValueWithReferrer(AtomicString(uri), completeURL(uri));
} else if (value->m_unit == CSSParserValue::Function && value->function->id == CSSValueWebkitImageSet) {
image = parseImageSet(m_valueList);
if (!image)
« no previous file with comments | « Source/core/css/parser/CSSPropertyParser.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698