extensions/renderer/script_injection_manager.cc - Issue 1335083004: [Extensions] Don't allow extensions to inject scripts into extension pages

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/script_injection_manager.cc

Issue 1335083004: [Extensions] Don't allow extensions to inject scripts into extension pages (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: extensions/renderer/script_injection_manager.cc

diff --git a/extensions/renderer/script_injection_manager.cc b/extensions/renderer/script_injection_manager.cc

index 895e25a92ebc5d967db784f49596881e711a09f8..ebf89e2745befdd4661afbba1073ea1d6c70f97d 100644

--- a/extensions/renderer/script_injection_manager.cc

+++ b/extensions/renderer/script_injection_manager.cc

@@ -413,8 +413,7 @@ void ScriptInjectionManager::HandleExecuteCode(

new ProgrammaticScriptInjector(params, render_frame)),

render_frame,

injection_host.Pass(),

- static_cast<UserScript::RunLocation>(params.run_at),

- ExtensionFrameHelper::Get(render_frame)->tab_id()));

+ static_cast<UserScript::RunLocation>(params.run_at)));

FrameStatusMap::const_iterator iter = frame_statuses_.find(render_frame);

UserScript::RunLocation run_location =

« no previous file with comments | « extensions/renderer/script_injection.cc ('k') | extensions/renderer/user_script_injector.cc » ('j') | no next file with comments »