[Extensions] Don't allow extensions to inject scripts into extension pages

extensions/renderer/user_script_injector.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/renderer/user_script_injector.h"
 
 #include <vector>
 
 #include "base/lazy_instance.h"
 #include "content/public/common/url_constants.h"
@@ skipping 136 matching lines @@
 bool UserScriptInjector::ShouldInjectCss(
     UserScript::RunLocation run_location) const {
   return run_location == UserScript::DOCUMENT_START &&
          !script_->css_scripts().empty();
 }
 
 PermissionsData::AccessType UserScriptInjector::CanExecuteOnFrame(
     const InjectionHost* injection_host,
     blink::WebLocalFrame* web_frame,
     int tab_id) const {
+  if (script_->consumer_instance_type() ==
+          UserScript::ConsumerInstanceType::WEBVIEW) {
+    int routing_id = content::RenderView::FromWebView(web_frame->top()->view())
+                        ->GetRoutingID();
+
+    RoutingInfoKey key(routing_id, script_->id());
+
+    RoutingInfoMap& map = g_routing_info_map.Get();
+    auto iter = map.find(key);
+
+    bool allowed = false;
+    if (iter != map.end()) {
+      allowed = iter->second;
+    } else {
+      // Send a SYNC IPC message to the browser to check if this is allowed.
+      // This is not ideal, but is mitigated by the fact that this is only done
+      // for webviews, and then only once per host.
+      // TODO(hanxi): Find a more efficient way to do this.
+      content::RenderThread::Get()->Send(
+          new ExtensionsGuestViewHostMsg_CanExecuteContentScriptSync(
+              routing_id, script_->id(), &allowed));
+      map.insert(std::pair<RoutingInfoKey, bool>(key, allowed));
+    }
+
+    return allowed ? PermissionsData::ACCESS_ALLOWED
+                   : PermissionsData::ACCESS_DENIED;
+  }
+
   GURL effective_document_url = ScriptContext::GetEffectiveDocumentURL(
       web_frame, web_frame->document().url(), script_->match_about_blank());
-  PermissionsData::AccessType can_execute = injection_host->CanExecuteOnFrame(
+
+  return injection_host->CanExecuteOnFrame(
       effective_document_url,
       content::RenderFrame::FromWebFrame(web_frame),
       tab_id,
       is_declarative_);
-  if (script_->consumer_instance_type() !=
-          UserScript::ConsumerInstanceType::WEBVIEW ||
-      can_execute == PermissionsData::ACCESS_DENIED)
-    return can_execute;
-
-  int routing_id = content::RenderView::FromWebView(web_frame->top()->view())
-                      ->GetRoutingID();
-
-  RoutingInfoKey key(routing_id, script_->id());
-
-  RoutingInfoMap& map = g_routing_info_map.Get();
-  auto iter = map.find(key);
-
-  bool allowed = false;
-  if (iter != map.end()) {
-    allowed = iter->second;
-  } else {
-    // Send a SYNC IPC message to the browser to check if this is allowed. This
-    // is not ideal, but is mitigated by the fact that this is only done for
-    // webviews, and then only once per host.
-    // TODO(hanxi): Find a more efficient way to do this.
-    content::RenderThread::Get()->Send(
-        new ExtensionsGuestViewHostMsg_CanExecuteContentScriptSync(
-            routing_id, script_->id(), &allowed));
-    map.insert(std::pair<RoutingInfoKey, bool>(key, allowed));
-  }
-
-  return allowed ? PermissionsData::ACCESS_ALLOWED
-                 : PermissionsData::ACCESS_DENIED;
 }
 
 std::vector<blink::WebScriptSource> UserScriptInjector::GetJsSources(
     UserScript::RunLocation run_location) const {
   DCHECK_EQ(script_->run_location(), run_location);
 
   std::vector<blink::WebScriptSource> sources;
   const UserScript::FileList& js_scripts = script_->js_scripts();
   bool is_standalone_or_emulate_greasemonkey =
       script_->is_standalone() || script_->emulate_greasemonkey();
@@ skipping 57 matching lines @@
 
 void UserScriptInjector::OnInjectionComplete(
     scoped_ptr<base::Value> execution_result,
     UserScript::RunLocation run_location) {
 }
 
 void UserScriptInjector::OnWillNotInject(InjectFailureReason reason) {
 }
 
 }  // namespace extensions