Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1335083002: Add emulation of transaction retries to memory impl of RunInTransaction. (Closed)

Created:
5 years, 3 months ago by Vadim Sh.
Modified:
5 years, 3 months ago
Reviewers:
iannucci
CC:
chromium-reviews, infra-reviews+luci-gae_chromium.org
Base URL:
https://github.com/luci/gae.git@master
Target Ref:
refs/heads/master
Project:
luci-gae
Visibility:
Public.

Description

Add emulation of transaction retries to memory impl of RunInTransaction. Available via Testable().SetTransactionRetryCount(). BUG=https://github.com/luci/gae/issues/2 R=iannucci@chromium.org Committed: https://github.com/luci/gae/commit/5364306d075accf356330f6933c578ba87604f4a

Patch Set 1 #

Total comments: 2

Patch Set 2 : behave identically to prod retry logic #

Total comments: 1

Patch Set 3 : add Testable() to non-Raw interfaces #

Unified diffs Side-by-side diffs Delta from patch set Stats (+114 lines, -29 lines) Patch
M impl/memory/context.go View 1 1 chunk +31 lines, -16 lines 0 comments Download
M impl/memory/datastore.go View 3 chunks +9 lines, -4 lines 0 comments Download
M impl/memory/datastore_query_execution_test.go View 1 2 1 chunk +1 line, -1 line 0 comments Download
M impl/memory/datastore_test.go View 1 2 4 chunks +58 lines, -4 lines 0 comments Download
M impl/memory/taskqueue_test.go View 1 2 4 chunks +4 lines, -4 lines 0 comments Download
M service/datastore/interface.go View 1 1 chunk +4 lines, -0 lines 0 comments Download
M service/datastore/testable.go View 1 chunk +5 lines, -0 lines 0 comments Download
M service/taskqueue/interface.go View 1 2 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (1 generated)
Vadim Sh.
5 years, 3 months ago (2015-09-11 01:42:56 UTC) #1
iannucci
lgtm w/ error nit https://codereview.chromium.org/1335083002/diff/1/impl/memory/context.go File impl/memory/context.go (right): https://codereview.chromium.org/1335083002/diff/1/impl/memory/context.go#newcode185 impl/memory/context.go:185: return ds.ErrConcurrentTransaction Can we return ...
5 years, 3 months ago (2015-09-11 22:31:11 UTC) #2
Vadim Sh.
https://codereview.chromium.org/1335083002/diff/1/impl/memory/context.go File impl/memory/context.go (right): https://codereview.chromium.org/1335083002/diff/1/impl/memory/context.go#newcode185 impl/memory/context.go:185: return ds.ErrConcurrentTransaction On 2015/09/11 22:31:11, iannucci wrote: > Can ...
5 years, 3 months ago (2015-09-14 01:07:20 UTC) #3
Vadim Sh.
Please take another look. Retry logic now matches what real GAE does (e.g. retry on ...
5 years, 3 months ago (2015-09-14 18:13:06 UTC) #4
Vadim Sh.
also added Testable() to non-raw Datastore and TaskQueue. https://codereview.chromium.org/1335083002/diff/20001/service/datastore/interface.go File service/datastore/interface.go (right): https://codereview.chromium.org/1335083002/diff/20001/service/datastore/interface.go#newcode147 service/datastore/interface.go:147: Testable() ...
5 years, 3 months ago (2015-09-14 18:16:18 UTC) #5
iannucci
On 2015/09/14 18:16:18, Vadim Sh. wrote: > also added Testable() to non-raw Datastore and TaskQueue. ...
5 years, 3 months ago (2015-09-14 18:19:26 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1335083002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1335083002/40001
5 years, 3 months ago (2015-09-14 18:20:57 UTC) #8
commit-bot: I haz the power
5 years, 3 months ago (2015-09-14 18:23:23 UTC) #9
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://github.com/luci/gae/commit/5364306d075accf356330f6933c578ba87604f4a

Powered by Google App Engine
This is Rietveld 408576698