Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(724)

Unified Diff: android_webview/browser/shared_renderer_state.cc

Issue 1335033004: Make sure FBO is correct for both kModeProcess and kModeDraw (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address comments Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « android_webview/browser/hardware_renderer.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/browser/shared_renderer_state.cc
diff --git a/android_webview/browser/shared_renderer_state.cc b/android_webview/browser/shared_renderer_state.cc
index cb0bda938b11ba71cd3133f8a2474c532e035721..69a41e53d3d0d33f621e93cee5bf714e0a277a1b 100644
--- a/android_webview/browser/shared_renderer_state.cc
+++ b/android_webview/browser/shared_renderer_state.cc
@@ -259,6 +259,18 @@ void SharedRendererState::DrawGL(AwDrawGLInfo* draw_info) {
draw_info->mode == AwDrawGLInfo::kModeDraw
? ScopedAppGLStateRestore::MODE_DRAW
: ScopedAppGLStateRestore::MODE_RESOURCE_MANAGEMENT);
+ // Set the correct FBO before kModeDraw. The GL commands run in kModeDraw
+ // require a correctly bound FBO. The FBO remains until the next kModeDraw.
+ // So kModeProcess between kModeDraws has correctly bound FBO, too.
+ if (draw_info->mode == AwDrawGLInfo::kModeDraw) {
+ if (!hardware_renderer_) {
+ hardware_renderer_.reset(new HardwareRenderer(this));
+ hardware_renderer_->CommitFrame();
+ }
+ hardware_renderer_->SetBackingFrameBufferObject(
+ state_restore.framebuffer_binding_ext());
+ }
+
ScopedAllowGL allow_gl;
if (draw_info->mode == AwDrawGLInfo::kModeProcessNoContext) {
@@ -279,14 +291,7 @@ void SharedRendererState::DrawGL(AwDrawGLInfo* draw_info) {
return;
}
- if (!hardware_renderer_) {
- hardware_renderer_.reset(new HardwareRenderer(this));
- hardware_renderer_->CommitFrame();
- }
-
- hardware_renderer_->DrawGL(state_restore.stencil_enabled(),
- state_restore.framebuffer_binding_ext(),
- draw_info);
+ hardware_renderer_->DrawGL(state_restore.stencil_enabled(), draw_info);
DeferredGpuCommandService::GetInstance()->PerformIdleWork(false);
}
« no previous file with comments | « android_webview/browser/hardware_renderer.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698