Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 133503012: Restrict sandbox/win/src/sandbox_types.h only on windows. (Closed)

Created:
6 years, 10 months ago by Haojian Wu
Modified:
6 years, 10 months ago
Reviewers:
brettw, Haojian Wu, sky
CC:
chromium-reviews, sadrul, tfarina, jam, joi+watch-content_chromium.org, darin-cc_chromium.org, ben+ash_chromium.org, kalyank, jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Restrict sandbox/win/src/sandbox_types.h only on windows. BUG=None TEST=compiled Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251270

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M ash/shell/shell_main.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/app/shell_main.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ui/views/examples/content_client/examples_main.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (0 generated)
Haojian Wu
Some cleanup. Please review it. Thanks.
6 years, 10 months ago (2014-02-01 12:05:45 UTC) #1
sky
LGTM
6 years, 10 months ago (2014-02-03 21:08:07 UTC) #2
Haojian Wu
The CQ bit was checked by hokein.wu@gmail.com
6 years, 10 months ago (2014-02-07 08:44:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/Hokein.Wu@gmail.com/133503012/1
6 years, 10 months ago (2014-02-07 08:47:30 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-07 09:08:51 UTC) #5
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=48871
6 years, 10 months ago (2014-02-07 09:08:51 UTC) #6
Haojian Wu
On 2014/02/07 09:08:51, I haz the power (commit-bot) wrote: > Retried try job too often ...
6 years, 10 months ago (2014-02-07 10:10:35 UTC) #7
Haojian Wu
On 2014/02/07 10:10:35, Haojian Wu wrote: > On 2014/02/07 09:08:51, I haz the power (commit-bot) ...
6 years, 10 months ago (2014-02-12 10:00:26 UTC) #8
brettw
lgtm
6 years, 10 months ago (2014-02-13 19:01:29 UTC) #9
Haojian Wu
The CQ bit was checked by hokein.wu@gmail.com
6 years, 10 months ago (2014-02-14 02:23:18 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/Hokein.Wu@gmail.com/133503012/1
6 years, 10 months ago (2014-02-14 02:23:54 UTC) #11
commit-bot: I haz the power
6 years, 10 months ago (2014-02-14 07:33:43 UTC) #12
Message was sent while issue was closed. 
Change committed as 251270

Powered by Google App Engine
This is Rietveld 408576698