Move files from //chrome/browser/sync to sync_driver component.

Move files from //chrome/browser/sync to sync_driver component.

This CL moves files that depend on the now-componentized data_type_controller.h
and data_type_manager.h into the sync_driver component. For the most part these
files are moved as-is. The only exception is sync_model_association_manager,
which had a DCHECK about being on BrowserThread::UI; this DCHECK is removed.

BUG=339726
TBR=joi

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248621

[blundell, 2014-02-01 13:18:32]

https://codereview.chromium.org/133503011/diff/1/components/sync_driver/model...
File components/sync_driver/model_association_manager.cc (left):

https://codereview.chromium.org/133503011/diff/1/components/sync_driver/model...
components/sync_driver/model_association_manager.cc:339:
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
Do you think it's worth preserving this DCHECK by injecting a ui_thread or using
a ThreadChecker (if this class is set up on the UI thread)?

[Nicolas Zea, 2014-02-03 19:21:35]

LGTM!

https://codereview.chromium.org/133503011/diff/1/components/sync_driver/model...
File components/sync_driver/model_association_manager.cc (left):

https://codereview.chromium.org/133503011/diff/1/components/sync_driver/model...
components/sync_driver/model_association_manager.cc:339:
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
On 2014/02/01 13:18:32, blundell wrote:
> Do you think it's worth preserving this DCHECK by injecting a ui_thread or
using
> a ThreadChecker (if this class is set up on the UI thread)?

Removing it is fine, all these classes are UI thread only.

[blundell, 2014-02-03 19:57:30]

The CQ bit was checked by blundell@chromium.org

[commit-bot: I haz the power, 2014-02-03 19:58:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/blundell@chromium.org/133503011/1

[commit-bot: I haz the power, 2014-02-03 20:21:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-03 20:21:39]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[commit-bot: I haz the power, 2014-02-03 20:21:48]

CQ bit was unchecked on CL. Ignoring.

[commit-bot: I haz the power, 2014-02-03 20:21:48]

CQ bit was unchecked on CL. Ignoring.

[blundell, 2014-02-03 20:27:30]

TBR=joi for components_tests.gypi

[blundell, 2014-02-03 20:27:48]

The CQ bit was checked by blundell@chromium.org

[commit-bot: I haz the power, 2014-02-03 20:28:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/blundell@chromium.org/133503011/1

[commit-bot: I haz the power, 2014-02-03 23:55:51]

Change committed as 248621

[commit-bot: I haz the power, 2014-02-03 23:55:52]

CQ bit was unchecked on CL. Ignoring.

[commit-bot: I haz the power, 2014-02-03 23:55:53]

CQ bit was unchecked on CL. Ignoring.

[commit-bot: I haz the power, 2014-02-03 23:55:56]

CQ bit was unchecked on CL. Ignoring.

[commit-bot: I haz the power, 2014-02-03 23:55:58]

CQ bit was unchecked on CL. Ignoring.

[commit-bot: I haz the power, 2014-02-03 23:57:11]

CQ bit was unchecked on CL. Ignoring.

[Jói, 2014-02-04 13:51:58]

components_tests.gypi LGTM

On Mon, Feb 3, 2014 at 11:57 PM,  <commit-bot@chromium.org> wrote:
> CQ bit was unchecked on CL. Ignoring.
>
> https://codereview.chromium.org/133503011/

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.