Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(842)

Issue 133503003: ninja win: Allow parent environment variables through when running actions (Closed)

Created:
6 years, 11 months ago by scottmg
Modified:
6 years, 11 months ago
Reviewers:
Nico
CC:
gyp-developer_googlegroups.com
Visibility:
Public.

Description

ninja win: Allow parent environment variables through when running actions This is a hack to get variables set here: https://code.google.com/p/chromium/codesearch#chromium/tools/build/scripts/slave/compile.py&l=416 through to version.py In preference to https://codereview.chromium.org/136163002/ as it doesn't involve trying to modify where the variables are set in master build scripts. TBR=thakis@chromium.org BUG=333738 Committed: https://code.google.com/p/gyp/source/detail?r=1836

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M pylib/gyp/win_tool.py View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
scottmg
6 years, 11 months ago (2014-01-13 03:20:52 UTC) #1
scottmg
This appears to work locally, so I'm going to TBR in an attempt to fix ...
6 years, 11 months ago (2014-01-13 03:28:14 UTC) #2
scottmg
Committed patchset #1 manually as r1836 (presubmit successful).
6 years, 11 months ago (2014-01-13 03:42:13 UTC) #3
Nico
Hm, this doesn't seem so horrible to me. It's how linux and mac work too, ...
6 years, 11 months ago (2014-01-14 02:10:02 UTC) #4
scottmg
6 years, 11 months ago (2014-01-14 03:29:54 UTC) #5
Message was sent while issue was closed.
On 2014/01/14 02:10:02, Nico wrote:
> Hm, this doesn't seem so horrible to me. It's how linux and mac work too, no?
> (except there aren't prebaked environments there, but you're only augmenting
> those)

That's right. It might be a bit confusing since e.g. PATH changes and other
things in the baked environment will be ignored, but other changes will make it
through.

Maybe not that big a deal though.

Powered by Google App Engine
This is Rietveld 408576698