Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issue 133503002: Quota: Implement StorageQuotaClient (Closed)

Created:
6 years, 11 months ago by nhiroki
Modified:
6 years, 11 months ago
Reviewers:
kinuko, abarth-chromium
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Quota: Implement StorageQuotaClient This change replaces StorageQuotaChromium with StorageQuotaClient for cleanup. BUG=n/a TEST=webkit/tools/layout_tests/run_webkit_tests.sh storage/\* Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165088

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+265 lines, -71 lines) Patch
M Source/modules/modules.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/modules/quota/StorageQuota.cpp View 2 chunks +15 lines, -0 lines 0 comments Download
A Source/modules/quota/StorageQuotaClient.h View 1 chunk +60 lines, -0 lines 0 comments Download
A Source/modules/quota/StorageQuotaClient.cpp View 1 chunk +54 lines, -0 lines 0 comments Download
D Source/web/StorageQuotaChromium.cpp View 1 chunk +0 lines, -70 lines 0 comments Download
A Source/web/StorageQuotaClientImpl.h View 1 chunk +53 lines, -0 lines 0 comments Download
A Source/web/StorageQuotaClientImpl.cpp View 1 chunk +77 lines, -0 lines 0 comments Download
M Source/web/WebViewImpl.cpp View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/web/web.gypi View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
nhiroki
Hi, can you review this? Thanks!
6 years, 11 months ago (2014-01-14 08:46:38 UTC) #1
kinuko
lgtm
6 years, 11 months ago (2014-01-14 08:59:49 UTC) #2
nhiroki
Hi abarth@, can you review Source/web/*? Thanks!
6 years, 11 months ago (2014-01-14 09:32:31 UTC) #3
abarth-chromium
lgtm
6 years, 11 months ago (2014-01-14 18:07:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nhiroki@chromium.org/133503002/190001
6 years, 11 months ago (2014-01-14 18:07:59 UTC) #5
commit-bot: I haz the power
6 years, 11 months ago (2014-01-14 19:25:14 UTC) #6
Message was sent while issue was closed.
Change committed as 165088

Powered by Google App Engine
This is Rietveld 408576698