Prepare MimeHanderViewContainer for removing swapped out RenderFrame.

extensions/renderer/guest_view/mime_handler_view/mime_handler_view_container.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/renderer/guest_view/mime_handler_view/mime_handler_view_container.h"
 
 #include <map>
 #include <set>
 
 #include "components/guest_view/common/guest_view_constants.h"
 #include "components/guest_view/common/guest_view_messages.h"
 #include "content/public/child/v8_value_converter.h"
 #include "content/public/renderer/render_frame.h"
 #include "content/public/renderer/render_view.h"
 #include "extensions/browser/guest_view/mime_handler_view/mime_handler_view_constants.h"
 #include "extensions/common/extension_messages.h"
 #include "extensions/common/guest_view/extensions_guest_view_messages.h"
 #include "gin/arguments.h"
 #include "gin/dictionary.h"
 #include "gin/handle.h"
 #include "gin/interceptor.h"
 #include "gin/object_template_builder.h"
 #include "gin/wrappable.h"
 #include "third_party/WebKit/public/web/WebDocument.h"
 #include "third_party/WebKit/public/web/WebLocalFrame.h"
+#include "third_party/WebKit/public/web/WebRemoteFrame.h"
 #include "third_party/WebKit/public/web/WebView.h"
 
 namespace extensions {
 
 namespace {
 
 const char kPostMessageName[] = "postMessage";
 
 // The gin-backed scriptable object which is exposed by the BrowserPlugin for
 // MimeHandlerViewContainer. This currently only implements "postMessage".
@@ skipping 192 matching lines @@
       content::RenderView::FromRoutingID(guest_proxy_routing_id_);
   if (!guest_proxy_render_view)
     return;
   blink::WebFrame* guest_proxy_frame =
       guest_proxy_render_view->GetWebView()->mainFrame();
   if (!guest_proxy_frame)
     return;
 
   v8::Context::Scope context_scope(
       render_frame()->GetWebFrame()->mainWorldScriptContext());
-  v8::Local<v8::Object> guest_proxy_window =
-      guest_proxy_frame->mainWorldScriptContext()->Global();
+
+  v8::Local<v8::Object> guest_proxy_window;
+  if (guest_proxy_frame->isWebLocalFrame()) {

[Fady Samuel, 2015/09/14 15:39:26]

A comment or helper method would be very useful here because it's not clear
what's going on.

[nasko, 2015/09/14 16:24:21]

Done.

+    guest_proxy_window =
+        guest_proxy_frame->mainWorldScriptContext()->Global();
+  } else {
+    guest_proxy_window = guest_proxy_frame->toWebRemoteFrame()
+                             ->deprecatedMainWorldScriptContext()
+                             ->Global();
+  }
   gin::Dictionary window_object(isolate, guest_proxy_window);
   v8::Local<v8::Function> post_message;
   if (!window_object.Get(std::string(kPostMessageName), &post_message))
     return;
 
   v8::Local<v8::Value> args[] = {
       message,
       // Post the message to any domain inside the browser plugin. The embedder
       // should already know what is embedded.
       gin::StringToV8(isolate, "*")};
-  guest_proxy_frame->callFunctionEvenIfScriptDisabled(
+  render_frame()->GetWebFrame()->callFunctionEvenIfScriptDisabled(

[Fady Samuel, 2015/09/14 15:38:05]

I thought we also wanted to avoid using callFunctionEvenIfScriptDisabled?

[nasko, 2015/09/14 15:39:19]

Yes, but on WebRemoteFrame, since it is not implemented. This calls it on the
WebLocalFrame, which means we plumb the postMessage call almost identically to
how it works in regular cases.

       post_message.As<v8::Function>(),
       guest_proxy_window,
       arraysize(args),
       args);
 }
 
 void MimeHandlerViewContainer::PostMessageFromValue(
     const base::Value& message) {
   blink::WebFrame* frame = render_frame()->GetWebFrame();
   if (!frame)
@@ skipping 58 matching lines @@
   if (!render_frame())
     return;
 
   render_frame()->Send(
       new ExtensionsGuestViewHostMsg_CreateMimeHandlerViewGuest(
           render_frame()->GetRoutingID(), view_id_, element_instance_id(),
           element_size_));
 }
 
 }  // namespace extensions