Issue 13350010: Windows: Do not initialize COM in the GPU process.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13350010: Windows: Do not initialize COM in the GPU process. (Closed)

Created:
7 years, 8 months ago by apatrick_chromium

Modified:
7 years, 8 months ago

Reviewers:
cpu_(ooo_6.6-7.5)

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, apatrick_chromium

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Windows: Do not initialize COM in the GPU process. The GPU process does not need COM so do not initialize it. Also, the initialization of COM was bogus. Look how the ScopedCOMInitializer is scoped. Initializing COM seems to be triggering a crash in the third party DLL cmsetac.dll BUG=225012 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=191890

Patch Set 1 #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -5 lines)			Patch
	M	content/gpu/gpu_main.cc	View		1 chunk	+0 lines, -5 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

7 years, 8 months ago (2013-04-02 17:57:58 UTC) #3

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/apatrick@chromium.org/13350010/1

Expand Messages | Collapse Messages