Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1101)

Issue 133493003: Implement Platform::createWaitableEvent() (chromium side) (Closed)

Created:
6 years, 11 months ago by kinuko
Modified:
6 years, 11 months ago
CC:
chromium-reviews, darin-cc_chromium.org
Visibility:
Public.

Description

Implement Platform::createWaitableEvent(): chromium side blink side: https://codereview.chromium.org/138303002/ BUG=334263 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245858

Patch Set 1 : #

Total comments: 4

Patch Set 2 : WebVector #

Patch Set 3 : #

Patch Set 4 : build fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -0 lines) Patch
M webkit/child/webkitplatformsupport_child_impl.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M webkit/child/webkitplatformsupport_child_impl.cc View 1 2 3 chunks +38 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
kinuko
Corresponding chromium patch. PTL
6 years, 11 months ago (2014-01-14 14:52:18 UTC) #1
jochen (gone - plz use gerrit)
https://codereview.chromium.org/133493003/diff/70001/webkit/child/webkitplatformsupport_child_impl.cc File webkit/child/webkitplatformsupport_child_impl.cc (right): https://codereview.chromium.org/133493003/diff/70001/webkit/child/webkitplatformsupport_child_impl.cc#newcode42 webkit/child/webkitplatformsupport_child_impl.cc:42: }; disallow copy/assign https://codereview.chromium.org/133493003/diff/70001/webkit/child/webkitplatformsupport_child_impl.cc#newcode111 webkit/child/webkitplatformsupport_child_impl.cc:111: size_t event_count) { why ...
6 years, 11 months ago (2014-01-14 15:29:11 UTC) #2
kinuko
https://codereview.chromium.org/133493003/diff/70001/webkit/child/webkitplatformsupport_child_impl.cc File webkit/child/webkitplatformsupport_child_impl.cc (right): https://codereview.chromium.org/133493003/diff/70001/webkit/child/webkitplatformsupport_child_impl.cc#newcode42 webkit/child/webkitplatformsupport_child_impl.cc:42: }; On 2014/01/14 15:29:12, jochen wrote: > disallow copy/assign ...
6 years, 11 months ago (2014-01-14 16:51:58 UTC) #3
jochen (gone - plz use gerrit)
lgtm
6 years, 11 months ago (2014-01-14 20:07:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinuko@chromium.org/133493003/190001
6 years, 11 months ago (2014-01-17 04:29:02 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_x64_rel for step(s) base_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_x64_rel&number=68249
6 years, 11 months ago (2014-01-17 06:30:31 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinuko@chromium.org/133493003/190001
6 years, 11 months ago (2014-01-20 03:53:39 UTC) #7
commit-bot: I haz the power
6 years, 11 months ago (2014-01-20 04:59:36 UTC) #8
Message was sent while issue was closed.
Change committed as 245858

Powered by Google App Engine
This is Rietveld 408576698