Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1334833003: Merge to XFA: Remove some abstractions in fxjs_v8.h. (Closed)

Created:
5 years, 3 months ago by Tom Sepez
Modified:
5 years, 3 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Merge to XFA: Remove some abstractions in fxjs_v8.h. Conflicts: fpdfsdk/src/javascript/Document.cpp fpdfsdk/src/javascript/JS_Runtime.cpp fpdfsdk/src/jsapi/fxjs_v8.cpp New: fpdfsdk/src/fpdfxfa/fpdfxfa_app.cpp (cherry picked from commit 6df59849472958e7de96da6d9fc7b223b7c1f1c3) Original Review URL: https://codereview.chromium.org/1332973002 . R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/808a99e8c6f72713ca9492508faa4b8445ae0d33

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+484 lines, -523 lines) Patch
M fpdfsdk/include/javascript/Consts.h View 9 chunks +13 lines, -15 lines 0 comments Download
M fpdfsdk/include/javascript/Document.h View 3 chunks +2 lines, -3 lines 0 comments Download
M fpdfsdk/include/javascript/Field.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/include/javascript/Icon.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/include/javascript/JS_Define.h View 9 chunks +63 lines, -61 lines 0 comments Download
M fpdfsdk/include/javascript/JS_Object.h View 2 chunks +2 lines, -2 lines 0 comments Download
M fpdfsdk/include/javascript/JS_Runtime.h View 3 chunks +3 lines, -7 lines 0 comments Download
M fpdfsdk/include/javascript/JS_Value.h View 2 chunks +3 lines, -3 lines 0 comments Download
M fpdfsdk/include/javascript/PublicMethods.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/include/javascript/app.h View 2 chunks +2 lines, -2 lines 0 comments Download
M fpdfsdk/include/javascript/color.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/include/javascript/console.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/include/javascript/event.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/include/javascript/global.h View 2 chunks +2 lines, -2 lines 0 comments Download
M fpdfsdk/include/javascript/report.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/include/javascript/util.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/include/jsapi/fxjs_v8.h View 3 chunks +46 lines, -56 lines 0 comments Download
M fpdfsdk/src/fpdfxfa/fpdfxfa_app.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/javascript/Consts.cpp View 6 chunks +24 lines, -24 lines 0 comments Download
M fpdfsdk/src/javascript/Document.cpp View 11 chunks +22 lines, -23 lines 0 comments Download
M fpdfsdk/src/javascript/Field.cpp View 2 chunks +6 lines, -4 lines 0 comments Download
M fpdfsdk/src/javascript/JS_Context.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/src/javascript/JS_EventHandler.cpp View 2 chunks +12 lines, -8 lines 0 comments Download
M fpdfsdk/src/javascript/JS_Object.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/javascript/JS_Runtime.cpp View 5 chunks +30 lines, -33 lines 0 comments Download
M fpdfsdk/src/javascript/JS_Value.cpp View 4 chunks +6 lines, -6 lines 0 comments Download
M fpdfsdk/src/javascript/app.cpp View 8 chunks +21 lines, -15 lines 0 comments Download
M fpdfsdk/src/javascript/global.cpp View 6 chunks +20 lines, -17 lines 0 comments Download
M fpdfsdk/src/jsapi/fxjs_v8.cpp View 25 chunks +195 lines, -230 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Tom Sepez
Lei, small manual changes as explained in the description.
5 years, 3 months ago (2015-09-10 19:14:22 UTC) #1
Lei Zhang
lgtm
5 years, 3 months ago (2015-09-10 19:16:35 UTC) #2
Tom Sepez
5 years, 3 months ago (2015-09-10 19:28:41 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
808a99e8c6f72713ca9492508faa4b8445ae0d33 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698