Chromium Code Reviews

Unified Diff: utils/tests/pub/io_test.dart

Issue 13348002: Make pub warning-clean. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
« no previous file with comments | « pkg/scheduled_test/lib/scheduled_test.dart ('k') | utils/tests/pub/test_pub.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: utils/tests/pub/io_test.dart
diff --git a/utils/tests/pub/io_test.dart b/utils/tests/pub/io_test.dart
index 585d068b2e1127db5bd4e7a70c0ee8cc01ebd786..72f6a390a376244491ca5f75fe855603cbff76fc 100644
--- a/utils/tests/pub/io_test.dart
+++ b/utils/tests/pub/io_test.dart
@@ -190,17 +190,17 @@ void testExistencePredicate(String name, bool predicate(String path),
group(name, () {
test('returns $forFile for a file', () {
expect(withTempDir((temp) {
- var path = path.join(temp, "test.txt");
- writeTextFile(path, "contents");
- expect(predicate(path), equals(forFile));
+ var txtPath = path.join(temp, "test.txt");
Bob Nystrom 2013/03/29 23:57:47 How about just "file"?
nweiz 2013/03/30 00:07:09 Done.
+ writeTextFile(txtPath, "contents");
+ expect(predicate(txtPath), equals(forFile));
}), completes);
});
test('returns $forDirectory for a directory', () {
expect(withTempDir((temp) {
- var path = path.join(temp, "dir");
- createDir(path);
- expect(predicate(path), equals(forDirectory));
+ var txtPath = path.join(temp, "dir");
+ createDir(txtPath);
+ expect(predicate(txtPath), equals(forDirectory));
}), completes);
});
« no previous file with comments | « pkg/scheduled_test/lib/scheduled_test.dart ('k') | utils/tests/pub/test_pub.dart » ('j') | no next file with comments »

Powered by Google App Engine