third_party/WebKit/Source/modules/bluetooth/BluetoothGATTCharacteristic.idl - Issue 1334763002: bluetooth: Subscribe to notifications

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/bluetooth/BluetoothGATTCharacteristic.idl

Issue 1334763002: bluetooth: Subscribe to notifications (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@bluetooth-origin

Patch Set: Fix global interface test Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/bluetooth/BluetoothGATTCharacteristic.cpp ('k') | third_party/WebKit/Source/modules/bluetooth/BluetoothSupplement.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/bluetooth/BluetoothGATTCharacteristic.idl

diff --git a/third_party/WebKit/Source/modules/bluetooth/BluetoothGATTCharacteristic.idl b/third_party/WebKit/Source/modules/bluetooth/BluetoothGATTCharacteristic.idl

index c3e0eea8152ffa1517c5889f96311c53b40cca8d..b6d8d57ea7241a3c634ddd698968639d6a78b9e9 100644

--- a/third_party/WebKit/Source/modules/bluetooth/BluetoothGATTCharacteristic.idl

+++ b/third_party/WebKit/Source/modules/bluetooth/BluetoothGATTCharacteristic.idl

@@ -8,6 +8,7 @@

[

GarbageCollected,

+ ActiveDOMObject,

RuntimeEnabled=WebBluetooth,

] interface BluetoothGATTCharacteristic {//: CharacteristicEventHandlers {

// TODO(ortuno): Add test to make sure service matches the service

@@ -20,6 +21,6 @@

// Promise<sequence<BluetoothGATTDescriptor>> getDescriptors(optional BluetoothDescriptorUUID descriptor);

[CallWith=ScriptState] Promise<ArrayBuffer> readValue();

[CallWith=ScriptState] Promise<void> writeValue(BufferSource value);

- // Promise<void> startNotifications();

- // Promise<void> stopNotifications();

+ [CallWith=ScriptState] Promise<void> startNotifications();

+ [CallWith=ScriptState] Promise<void> stopNotifications();

};